aboutsummaryrefslogtreecommitdiffstats
path: root/.lgtm
diff options
context:
space:
mode:
authorJason Song <i@wolfogre.com>2022-11-28 19:19:18 +0800
committerGitHub <noreply@github.com>2022-11-28 11:19:18 +0000
commit9607750b5e9001ab379fa8deab0dadbb6219c66e (patch)
treedbdd22fbe52114b852d75f7f108342570bd81eeb /.lgtm
parente81ccc406bf723a5a58d685e7782f281736affd4 (diff)
downloadgitea-9607750b5e9001ab379fa8deab0dadbb6219c66e.tar.gz
gitea-9607750b5e9001ab379fa8deab0dadbb6219c66e.zip
Replace fmt.Sprintf with hex.EncodeToString (#21960)
`hex.EncodeToString` has better performance than `fmt.Sprintf("%x", []byte)`, we should use it as much as possible. I'm not an extreme fan of performance, so I think there are some exceptions: - `fmt.Sprintf("%x", func(...)[N]byte())` - We can't slice the function return value directly, and it's not worth adding lines. ```diff func A()[20]byte { ... } - a := fmt.Sprintf("%x", A()) - a := hex.EncodeToString(A()[:]) // invalid + tmp := A() + a := hex.EncodeToString(tmp[:]) ``` - `fmt.Sprintf("%X", []byte)` - `strings.ToUpper(hex.EncodeToString(bytes))` has even worse performance.
Diffstat (limited to '.lgtm')
0 files changed, 0 insertions, 0 deletions