diff options
| author | Lunny Xiao <xiaolunwen@gmail.com> | 2022-02-20 18:28:58 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-20 10:28:58 +0000 |
| commit | 00be0c1b219ee74ca3e09e584d260f18e7f36aff (patch) | |
| tree | ff303359afbe05df2d72a83e93dde713f5536885 | |
| parent | d5a4c5530a452e1bb32285d1171064ebe9ddfb70 (diff) | |
| download | gitea-00be0c1b219ee74ca3e09e584d260f18e7f36aff.tar.gz gitea-00be0c1b219ee74ca3e09e584d260f18e7f36aff.zip | |
Fix login with email for ldap users (#18800)
`authenticator.Authenticate` has assume the login name is not an email, but `username` maybe an email. So when we find the user via email address, we should use `user.LoginName` instead of `username` which is an email address.
| -rw-r--r-- | services/auth/signin.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/auth/signin.go b/services/auth/signin.go index a6f2d14b5c..1b5b7f5d2a 100644 --- a/services/auth/signin.go +++ b/services/auth/signin.go @@ -65,7 +65,7 @@ func UserSignIn(username, password string) (*user_model.User, *auth.Source, erro return nil, nil, smtp.ErrUnsupportedLoginType } - user, err := authenticator.Authenticate(user, username, password) + user, err := authenticator.Authenticate(user, user.LoginName, password) if err != nil { return nil, nil, err } |