diff options
| author | Giteabot <teabot@gitea.io> | 2023-07-14 05:32:43 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-14 09:32:43 +0000 |
| commit | 026e745b9e3737655189b4c351b43133574235dd (patch) | |
| tree | bf3b90a169d28d35a8ca9eef832d9ead78d1f058 | |
| parent | c334be82840f8c55a50d468a6771e1c390efe4c3 (diff) | |
| download | gitea-026e745b9e3737655189b4c351b43133574235dd.tar.gz gitea-026e745b9e3737655189b4c351b43133574235dd.zip | |
Fix incorrect release count (#25879) (#25887)
Backport #25879 by @yp05327
Release count is not correct:
https://try.gitea.io/yp05327/testrepo/tags
https://try.gitea.io/yp05327/testrepo/releases
https://try.gitea.io/yp05327/testrepo/releases/tag/testtag
We already have correct release count, no need to calculate it again.
https://github.com/go-gitea/gitea/blob/c5e187c389b35b9e080a3187b93a775a3c81e585/modules/context/repo.go#L547
Co-authored-by: yp05327 <576951401@qq.com>
| -rw-r--r-- | routers/web/repo/release.go | 1 | ||||
| -rw-r--r-- | templates/repo/release_tag_header.tmpl | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go index 0b927a3a2f..8dc78079e2 100644 --- a/routers/web/repo/release.go +++ b/routers/web/repo/release.go @@ -196,7 +196,6 @@ func releasesOrTags(ctx *context.Context, isTagList bool) { } ctx.Data["Releases"] = releases - ctx.Data["ReleasesNum"] = len(releases) pager := context.NewPagination(int(count), opts.PageSize, opts.Page, 5) pager.SetDefaultParams(ctx) diff --git a/templates/repo/release_tag_header.tmpl b/templates/repo/release_tag_header.tmpl index 7129e4235f..3f6f9aac31 100644 --- a/templates/repo/release_tag_header.tmpl +++ b/templates/repo/release_tag_header.tmpl @@ -5,7 +5,7 @@ <div class="gt-df"> <div class="gt-f1 gt-df gt-ac"> <h2 class="ui compact small menu header small-menu-items"> - <a class="{{if .PageIsReleaseList}}active {{end}}item" href="{{.RepoLink}}/releases">{{.locale.PrettyNumber .ReleasesNum}} {{.locale.TrN .ReleasesNum "repo.release" "repo.releases"}}</a> + <a class="{{if .PageIsReleaseList}}active {{end}}item" href="{{.RepoLink}}/releases">{{.locale.PrettyNumber .NumReleases}} {{.locale.TrN .NumReleases "repo.release" "repo.releases"}}</a> {{if $canReadCode}} <a class="{{if .PageIsTagList}}active {{end}}item" href="{{.RepoLink}}/tags">{{.locale.PrettyNumber .NumTags}} {{.locale.TrN .NumTags "repo.tag" "repo.tags"}}</a> {{end}} |