diff options
| author | Jonas Franz <info@jonasfranz.software> | 2018-05-29 05:51:42 +0200 |
|---|---|---|
| committer | techknowlogick <techknowlogick@users.noreply.github.com> | 2018-05-28 23:51:42 -0400 |
| commit | 2139c152cbf856b62e636df3b4dee784847b3a25 (patch) | |
| tree | b9a73f39f9b8cd0f993b36e7d7bfa27b9ea4ac33 | |
| parent | f86f56e19c5ef1b19eb58d888cbab25cf4b28704 (diff) | |
| download | gitea-2139c152cbf856b62e636df3b4dee784847b3a25.tar.gz gitea-2139c152cbf856b62e636df3b4dee784847b3a25.zip | |
Fix relative markdown links with anchors (#4058)
* Replace '%28' with '#'
Add test case
Signed-off-by: Jonas Franz <info@jonasfranz.software>
* Use ResolveReference instead of strings.Replace
Signed-off-by: Jonas Franz <info@jonasfranz.software>
| -rw-r--r-- | modules/util/util.go | 22 | ||||
| -rw-r--r-- | modules/util/util_test.go | 2 |
2 files changed, 18 insertions, 6 deletions
diff --git a/modules/util/util.go b/modules/util/util.go index 3a0411f64b..4bd2b843f7 100644 --- a/modules/util/util.go +++ b/modules/util/util.go @@ -7,6 +7,7 @@ package util import ( "net/url" "path" + "strings" "code.gitea.io/gitea/modules/log" ) @@ -56,16 +57,25 @@ func Max(a, b int) int { // URLJoin joins url components, like path.Join, but preserving contents func URLJoin(base string, elems ...string) string { - u, err := url.Parse(base) + if !strings.HasSuffix(base, "/") { + base += "/" + } + baseURL, err := url.Parse(base) if err != nil { log.Error(4, "URLJoin: Invalid base URL %s", base) return "" } - joinArgs := make([]string, 0, len(elems)+1) - joinArgs = append(joinArgs, u.Path) - joinArgs = append(joinArgs, elems...) - u.Path = path.Join(joinArgs...) - return u.String() + joinedPath := path.Join(elems...) + argURL, err := url.Parse(joinedPath) + if err != nil { + log.Error(4, "URLJoin: Invalid arg %s", joinedPath) + return "" + } + joinedURL := baseURL.ResolveReference(argURL).String() + if !baseURL.IsAbs() { + return joinedURL[1:] // Removing leading '/' + } + return joinedURL } // Min min of two ints diff --git a/modules/util/util_test.go b/modules/util/util_test.go index cc5875263a..67d9efe1d2 100644 --- a/modules/util/util_test.go +++ b/modules/util/util_test.go @@ -30,6 +30,8 @@ func TestURLJoin(t *testing.T) { "a", "b/c/"), newTest("a/b/d", "a/", "b/c/", "/../d/"), + newTest("https://try.gitea.io/a/b/c#d", + "https://try.gitea.io", "a/b", "c#d"), } { assert.Equal(t, test.Expected, URLJoin(test.Base, test.Elements...)) } |