diff options
| author | yp05327 <576951401@qq.com> | 2023-05-09 13:50:16 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-09 00:50:16 -0400 |
| commit | 2ee72d011fa05852ba4117a8b849fde32cbd54e7 (patch) | |
| tree | 93653c3d51c3effe34c1f369812a3bb903421dcb | |
| parent | d5b2bf9044caad9fb473312c4816f6c6caad4698 (diff) | |
| download | gitea-2ee72d011fa05852ba4117a8b849fde32cbd54e7.tar.gz gitea-2ee72d011fa05852ba4117a8b849fde32cbd54e7.zip | |
Add permission check for moving issue action in project view page (#24589)
Fix #22954
Only users who have write permission can move issues in the project view page.
| -rw-r--r-- | templates/projects/view.tmpl | 2 | ||||
| -rw-r--r-- | web_src/css/features/projects.css | 5 | ||||
| -rw-r--r-- | web_src/js/features/repo-projects.js | 2 |
3 files changed, 6 insertions, 3 deletions
diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index 705ce52d6c..3274463435 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -73,7 +73,7 @@ </div> <div class="ui container fluid padded" id="project-board"> - <div class="board"> + <div class="board {{if .CanWriteProjects}}sortable{{end}}"> {{range $board := .Boards}} <div class="ui segment board-column" style="background: {{.Color}} !important;" data-id="{{.ID}}" data-sorting="{{.Sorting}}" data-url="{{$.Link}}/{{.ID}}"> diff --git a/web_src/css/features/projects.css b/web_src/css/features/projects.css index 2bc68ccf0d..bd48429fa6 100644 --- a/web_src/css/features/projects.css +++ b/web_src/css/features/projects.css @@ -6,6 +6,10 @@ margin: 0 0.5em; } +.board.sortable .board-card { + cursor: move; +} + .board-column { background-color: var(--color-project-board-bg) !important; border: 1px solid var(--color-secondary) !important; @@ -80,7 +84,6 @@ .board-card { margin: 4px 2px !important; border-radius: 5px !important; - cursor: move; width: calc(100% - 4px) !important; padding: 0.5rem !important; min-height: auto !important; diff --git a/web_src/js/features/repo-projects.js b/web_src/js/features/repo-projects.js index cd38c41e2d..11f5518283 100644 --- a/web_src/js/features/repo-projects.js +++ b/web_src/js/features/repo-projects.js @@ -36,7 +36,7 @@ function moveIssue({item, from, to, oldIndex}) { } async function initRepoProjectSortable() { - const els = document.querySelectorAll('#project-board > .board'); + const els = document.querySelectorAll('#project-board > .board.sortable'); if (!els.length) return; const {Sortable} = await import(/* webpackChunkName: "sortable" */'sortablejs'); |