diff options
| author | Andrey Nering <andrey.nering@gmail.com> | 2016-11-24 23:25:34 -0200 |
|---|---|---|
| committer | Lunny Xiao <xiaolunwen@gmail.com> | 2016-11-25 09:25:34 +0800 |
| commit | 6a28909f40ad1ff20d325d9be4ada87e5b75ce53 (patch) | |
| tree | 6fc3a41bcc239581a7200887ae708929777a5fad | |
| parent | 21e8deed897a99fc86cd6506ce1bf4a9a8c07fba (diff) | |
| download | gitea-6a28909f40ad1ff20d325d9be4ada87e5b75ce53.tar.gz gitea-6a28909f40ad1ff20d325d9be4ada87e5b75ce53.zip | |
CONTRIBUTING.md: link to "Faster reviews" document (#229)
* CONTRIBUTING.md: link to "Faster reviews" document
* CONTRIBUTING.md: small fixes
| -rw-r--r-- | CONTRIBUTING.md | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3f6ded7e16..752e02015f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -76,6 +76,19 @@ who makes the change even if an owners or a maintainer. We use github's pull request workflow to do that and use [lgtm](http://lgtm.co) to ensure every PR is reviewed by at least 2 maintainers. +Please try to make your pull request easy to review for us. Please read the +["How to get faster PR reviews"](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md), +guide, it got useful tips for any project you may want to contribute. See some +of the points: + +- Make small pull requests. The smaller, the faster to review and the more + likely it will be merged soon. +- Don't make changes unrelated to your PR. Maybe there are typos on some + comments, maybe refactoring would welcome on a function... but if that is not + related to you PR, please make *another* PR for that. +- Split big pull requests in multiple. An incremental change will be faster to + review than a huge PR. + ## Sign your work The sign-off is a simple line at the end of the explanation for the |