diff options
| author | Giteabot <teabot@gitea.io> | 2023-07-28 17:08:11 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-28 11:08:11 +0200 |
| commit | ecfbcced46d7a4489fcb94cca138110434423b82 (patch) | |
| tree | 22df28790d2a23eab141af5018d85c1d3428b837 | |
| parent | 892e24aaf1b7b623fde20babdff5826158e0e385 (diff) | |
| download | gitea-ecfbcced46d7a4489fcb94cca138110434423b82.tar.gz gitea-ecfbcced46d7a4489fcb94cca138110434423b82.zip | |
Prevent primary key update on migration (#26192) (#26199)
Backport #26192 by @KN4CK3R
Fixes #25918
The migration fails on MSSQL because xorm tries to update the primary
key column. xorm prevents this if the column is marked as auto
increment:
https://gitea.com/xorm/xorm/src/commit/c622cdaf893fbfe3f40a6b79f6bc17ee10f53865/internal/statements/update.go#L38-L40
I think it would be better if xorm would check for primary key columns
here because updating such columns is bad practice. It looks like if
that auto increment check should do the same.
fyi @lunny
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
| -rw-r--r-- | models/migrations/v1_20/v250.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/models/migrations/v1_20/v250.go b/models/migrations/v1_20/v250.go index e05646e5c6..a09957b291 100644 --- a/models/migrations/v1_20/v250.go +++ b/models/migrations/v1_20/v250.go @@ -20,7 +20,7 @@ func ChangeContainerMetadataMultiArch(x *xorm.Engine) error { } type PackageVersion struct { - ID int64 `xorm:"pk"` + ID int64 `xorm:"pk autoincr"` MetadataJSON string `xorm:"metadata_json"` } |