diff options
author | Nanguan Lin <70063547+lng2020@users.noreply.github.com> | 2024-01-13 00:49:02 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-01-12 16:49:02 +0000 |
commit | 9b59af37e72656c71316ec79b5c377a2eb84c671 (patch) | |
tree | a6d7ca55c2e4f91ae6bb2cfba3380031863a82fb /build.go | |
parent | 4f8f5f6e251615265392ec4212ed87a58fb1f75e (diff) | |
download | gitea-9b59af37e72656c71316ec79b5c377a2eb84c671.tar.gz gitea-9b59af37e72656c71316ec79b5c377a2eb84c671.zip |
Fix issue dependencies (#27736)
Fix #27722
Fix #27357
Fix #25837
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.
![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)
Diffstat (limited to 'build.go')
0 files changed, 0 insertions, 0 deletions