aboutsummaryrefslogtreecommitdiffstats
path: root/contrib/legal
diff options
context:
space:
mode:
authorLunny Xiao <xiaolunwen@gmail.com>2023-12-19 15:20:47 +0800
committerGitHub <noreply@github.com>2023-12-19 07:20:47 +0000
commit4eb2a29910779ac6005a5d67f31067a1132c5297 (patch)
tree6be901075430e94785bc37ac4ec67392a17ed868 /contrib/legal
parent128eac9e0b03ee9c1e45dbd49da8e4726ca569f2 (diff)
downloadgitea-4eb2a29910779ac6005a5d67f31067a1132c5297.tar.gz
gitea-4eb2a29910779ac6005a5d67f31067a1132c5297.zip
Improve ObjectFormat interface (#28496)
The 4 functions are duplicated, especially as interface methods. I think we just need to keep `MustID` the only one and remove other 3. ``` MustID(b []byte) ObjectID MustIDFromString(s string) ObjectID NewID(b []byte) (ObjectID, error) NewIDFromString(s string) (ObjectID, error) ``` Introduced the new interfrace method `ComputeHash` which will replace the interface `HasherInterface`. Now we don't need to keep two interfaces. Reintroduced `git.NewIDFromString` and `git.MustIDFromString`. The new function will detect the hash length to decide which objectformat of it. If it's 40, then it's SHA1. If it's 64, then it's SHA256. This will be right if the commitID is a full one. So the parameter should be always a full commit id. @AdamMajer Please review.
Diffstat (limited to 'contrib/legal')
0 files changed, 0 insertions, 0 deletions