diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-04-11 16:36:18 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-11 16:36:18 +0800 |
| commit | 704f3aa91c05aeab7ba18bda62f768ab9233cf6f (patch) | |
| tree | 4549babe888daf066836f8fe9ae26b3309480a85 /docs/content/doc/installation | |
| parent | 91c8261e2cc479af127fb7b1e0803cd0f57d65f7 (diff) | |
| download | gitea-704f3aa91c05aeab7ba18bda62f768ab9233cf6f.tar.gz gitea-704f3aa91c05aeab7ba18bda62f768ab9233cf6f.zip | |
Fine tune markdown editor toolbar (#24046)
1. Remove unnecessary `btn-link` `muted` classes
* Link is link, button is button, I can't see a real requirement to make
a button like a link.
* If anyone insists, please help to show me real example from modern
frameworks / websites, how and why they do so.
* No need to duplicate a lot of class names on similar elements
* Declare styles clearly, for example, `markdown-toolbar` itself should
have `display: flex`, but not use `gt-df` to overwrite the `display:
block`.
2. Remove unnecessary `role` attribute
* https://github.com/github/markdown-toolbar-element/issues/70
* The `markdown-toolbar-element` does want to add `role=button`, but
there is a bug.
* So we do the similar thing as upstream does (add the role by JS),
until they fix their bugs.
3. Indent `markdown-switch-easymde` (before it doesn't have a proper
indent)
Screenshot:
Diffstat (limited to 'docs/content/doc/installation')
0 files changed, 0 insertions, 0 deletions