diff options
author | wxiaoguang <wxiaoguang@gmail.com> | 2021-10-21 15:37:43 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-21 15:37:43 +0800 |
commit | 2add8fe9beede4aa82c913fcb70c0cf5bb1c6185 (patch) | |
tree | be2555d0a8f0ae926d56eefd3a3b3e533985074a /integrations | |
parent | 5879ab83b5fab57a71aed4c8b3c4d9293b4a4398 (diff) | |
download | gitea-2add8fe9beede4aa82c913fcb70c0cf5bb1c6185.tar.gz gitea-2add8fe9beede4aa82c913fcb70c0cf5bb1c6185.zip |
Frontend refactor, PascalCase to camelCase, remove unused code (#17365)
* Frontend refactor, PascalCase to camelCase, remove unused code
* fix
Diffstat (limited to 'integrations')
-rw-r--r-- | integrations/branches_test.go | 9 | ||||
-rw-r--r-- | integrations/html_helper.go | 2 | ||||
-rw-r--r-- | integrations/pull_create_test.go | 4 |
3 files changed, 4 insertions, 11 deletions
diff --git a/integrations/branches_test.go b/integrations/branches_test.go index b2230e7031..aa4df6ac6a 100644 --- a/integrations/branches_test.go +++ b/integrations/branches_test.go @@ -9,7 +9,6 @@ import ( "net/url" "testing" - "github.com/PuerkitoBio/goquery" "github.com/stretchr/testify/assert" "github.com/unknwon/i18n" ) @@ -62,7 +61,7 @@ func branchAction(t *testing.T, button string) (*HTMLDoc, string) { } req = NewRequestWithValues(t, "POST", link, map[string]string{ - "_csrf": getCsrf(t, htmlDoc.doc), + "_csrf": htmlDoc.GetCSRF(), }) session.MakeRequest(t, req, http.StatusOK) @@ -73,9 +72,3 @@ func branchAction(t *testing.T, button string) (*HTMLDoc, string) { return NewHTMLParser(t, resp.Body), url.Query().Get("name") } - -func getCsrf(t *testing.T, doc *goquery.Document) string { - csrf, exists := doc.Find("meta[name=\"_csrf\"]").Attr("content") - assert.True(t, exists) - return csrf -} diff --git a/integrations/html_helper.go b/integrations/html_helper.go index 6dc806a76e..001fc9a05b 100644 --- a/integrations/html_helper.go +++ b/integrations/html_helper.go @@ -44,7 +44,7 @@ func (doc *HTMLDoc) Find(selector string) *goquery.Selection { return doc.doc.Find(selector) } -// GetCSRF for get CSRC token value from input +// GetCSRF for getting CSRF token value from input func (doc *HTMLDoc) GetCSRF() string { return doc.GetInputValueByName("_csrf") } diff --git a/integrations/pull_create_test.go b/integrations/pull_create_test.go index 5a0a3eda08..948c0b9ce2 100644 --- a/integrations/pull_create_test.go +++ b/integrations/pull_create_test.go @@ -114,7 +114,7 @@ func testUIDeleteBranch(t *testing.T, session *TestSession, ownerName, repoName, htmlDoc := NewHTMLParser(t, resp.Body) req = NewRequestWithValues(t, "POST", relURL+"/delete", map[string]string{ - "_csrf": getCsrf(t, htmlDoc.doc), + "_csrf": htmlDoc.GetCSRF(), "name": branchName, }) session.MakeRequest(t, req, http.StatusOK) @@ -127,7 +127,7 @@ func testDeleteRepository(t *testing.T, session *TestSession, ownerName, repoNam htmlDoc := NewHTMLParser(t, resp.Body) req = NewRequestWithValues(t, "POST", relURL+"?action=delete", map[string]string{ - "_csrf": getCsrf(t, htmlDoc.doc), + "_csrf": htmlDoc.GetCSRF(), "repo_name": repoName, }) session.MakeRequest(t, req, http.StatusFound) |