aboutsummaryrefslogtreecommitdiffstats
path: root/integrations
diff options
context:
space:
mode:
authorGusted <williamzijl7@hotmail.com>2022-02-04 18:03:15 +0100
committerGitHub <noreply@github.com>2022-02-04 18:03:15 +0100
commitaa23f477b7f66273f7e9551282230386b7de2d8a (patch)
tree4f53bf59f35b023af6e485fb590dc554f4bc0d8d /integrations
parent88939a5663bbb4547f45421a846ec4420283d996 (diff)
downloadgitea-aa23f477b7f66273f7e9551282230386b7de2d8a.tar.gz
gitea-aa23f477b7f66273f7e9551282230386b7de2d8a.zip
Use `CryptoRandomBytes` instead of `CryptoRandomString` (#18439)
- Switch to use `CryptoRandomBytes` instead of `CryptoRandomString`, OAuth's secrets are copied pasted and don't need to avoid dubious characters etc. - `CryptoRandomBytes` gives ![2^256 = 1.15 * 10^77](https://render.githubusercontent.com/render/math?math=2^256%20=%201.15%20\cdot%2010^77) `CryptoRandomString` gives ![62^44 = 7.33 * 10^78](https://render.githubusercontent.com/render/math?math=62^44%20=%207.33%20\cdot%2010^78) possible states. - Add a prefix, such that code scanners can easily grep these in source code. - 32 Bytes + prefix
Diffstat (limited to 'integrations')
-rw-r--r--integrations/api_oauth2_apps_test.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/integrations/api_oauth2_apps_test.go b/integrations/api_oauth2_apps_test.go
index e51549568a..2c08338b25 100644
--- a/integrations/api_oauth2_apps_test.go
+++ b/integrations/api_oauth2_apps_test.go
@@ -43,7 +43,7 @@ func testAPICreateOAuth2Application(t *testing.T) {
DecodeJSON(t, resp, &createdApp)
assert.EqualValues(t, appBody.Name, createdApp.Name)
- assert.Len(t, createdApp.ClientSecret, 44)
+ assert.Len(t, createdApp.ClientSecret, 56)
assert.Len(t, createdApp.ClientID, 36)
assert.NotEmpty(t, createdApp.Created)
assert.EqualValues(t, appBody.RedirectURIs[0], createdApp.RedirectURIs[0])