diff options
| author | Philip Peterson <1326208+philip-peterson@users.noreply.github.com> | 2025-05-27 12:36:02 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-05-27 19:36:02 +0000 |
| commit | b0936f4f4120169fab31f21610e9fcd915e36fb4 (patch) | |
| tree | aab7055e593301436fd7c8aa2a998106951b97ac /models/git/commit_status_test.go | |
| parent | 498088c0536f228eceb7c04ab53742f69a0024b4 (diff) | |
| download | gitea-b0936f4f4120169fab31f21610e9fcd915e36fb4.tar.gz gitea-b0936f4f4120169fab31f21610e9fcd915e36fb4.zip | |
Do not mutate incoming options to RenderUserSearch and SearchUsers (#34544)
This PR changes the `opts` argument in `SearchUsers()` to be passed by
value instead of by pointer, as its mutations do not escape the function
scope and are not used elsewhere. This simplifies reasoning about the
function and avoids unnecessary pointer usage.
This insight emerged during an initial attempt to refactor
`RenderUserSearch()`, which currently intermixes multiple concerns.
Co-authored-by: Philip Peterson <philip-peterson@users.noreply.github.com>
Diffstat (limited to 'models/git/commit_status_test.go')
0 files changed, 0 insertions, 0 deletions