Create Proper Migration Tests (#15116)

* Create Proper Migration tests

Unfortunately our testing regime has so far meant that migrations do not
get proper testing.

This PR begins the process of creating migration tests for this.

* Add test for v176

* fix mssql drop db

Signed-off-by: Andrew Thornton <art27@cantab.net>

7 files changed, 223 insertions, 0 deletions

diff --git a/models/migrations/fixtures/Test_deleteOrphanedIssueLabels/issue_label.yml b/models/migrations/fixtures/Test_deleteOrphanedIssueLabels/issue_label.yml
new file mode 100644
index 0000000000..96104ac04a
--- /dev/null
+++ b/models/migrations/fixtures/Test_deleteOrphanedIssueLabels/issue_label.yml
@@ -0,0 +1,29 @@
+# Issue_Label 1 should not be deleted
+-
+  id: 1
+  issue_id: 1
+  label_id: 1
+
+# Issue_label 2 should be deleted
+-
+  id: 2
+  issue_id: 5
+  label_id: 99
+
+# Issue_Label 3 should not be deleted
+-
+  id: 3
+  issue_id: 2
+  label_id: 1
+
+# Issue_Label 4 should not be deleted
+-
+  id: 4
+  issue_id: 2
+  label_id: 4
+
+-
+  id: 5
+  issue_id: 2
+  label_id: 87
+
diff --git a/models/migrations/fixtures/Test_deleteOrphanedIssueLabels/label.yml b/models/migrations/fixtures/Test_deleteOrphanedIssueLabels/label.yml
new file mode 100644
index 0000000000..d651c87d5b
--- /dev/null
+++ b/models/migrations/fixtures/Test_deleteOrphanedIssueLabels/label.yml
@@ -0,0 +1,43 @@
+-
+  id: 1
+  repo_id: 1
+  org_id: 0
+  name: label1
+  color: '#abcdef'
+  num_issues: 2
+  num_closed_issues: 0
+
+-
+  id: 2
+  repo_id: 1
+  org_id: 0
+  name: label2
+  color: '#000000'
+  num_issues: 1
+  num_closed_issues: 1
+-
+  id: 3
+  repo_id: 0
+  org_id:  3
+  name: orglabel3
+  color: '#abcdef'
+  num_issues: 0
+  num_closed_issues: 0
+
+-
+  id: 4
+  repo_id: 0
+  org_id: 3
+  name: orglabel4
+  color: '#000000'
+  num_issues: 1
+  num_closed_issues: 0
+
+-
+  id: 5
+  repo_id: 10
+  org_id: 0
+  name: pull-test-label
+  color: '#000000'
+  num_issues: 0
+  num_closed_issues: 0
diff --git a/models/migrations/fixtures/Test_removeInvalidLabels/comment.yml b/models/migrations/fixtures/Test_removeInvalidLabels/comment.yml
new file mode 100644
index 0000000000..4f44e29661
--- /dev/null
+++ b/models/migrations/fixtures/Test_removeInvalidLabels/comment.yml
@@ -0,0 +1,52 @@
+# type Comment struct {
+#   ID      int64 `xorm:"pk autoincr"`
+#   Type    int   `xorm:"INDEX"`
+#   IssueID int64 `xorm:"INDEX"`
+#   LabelID int64
+# }
+#
+# we are only interested in type 7
+#
+
+-
+  id: 1 # Should remain
+  type: 6
+  issue_id: 1
+  label_id: 0
+  should_remain: true
+-
+  id: 2 # Should remain
+  type: 7
+  issue_id: 1 # repo_id: 1
+  label_id: 1 # repo_id: 1
+  should_remain: true
+-
+  id: 3 # Should remain
+  type: 7
+  issue_id: 2 # repo_id: 2 owner_id: 1
+  label_id: 2 # org_id: 1
+  should_remain: true
+-
+  id: 4 # Should be DELETED
+  type: 7
+  issue_id: 1 # repo_id: 1
+  label_id: 3 # repo_id: 2
+  should_remain: false
+-
+  id: 5 # Should remain
+  type: 7
+  issue_id: 3 # repo_id: 1
+  label_id: 1 # repo_id: 1
+  should_remain: true
+-
+  id: 6 # Should be DELETED
+  type: 7
+  issue_id: 3 # repo_id: 1 owner_id: 2
+  label_id: 2 # org_id: 1
+  should_remain: false
+-
+  id: 7 # Should be DELETED
+  type: 7
+  issue_id: 3 # repo_id: 1 owner_id: 2
+  label_id: 5 # repo_id: 3
+  should_remain: false
diff --git a/models/migrations/fixtures/Test_removeInvalidLabels/issue.yml b/models/migrations/fixtures/Test_removeInvalidLabels/issue.yml
new file mode 100644
index 0000000000..46ad46c174
--- /dev/null
+++ b/models/migrations/fixtures/Test_removeInvalidLabels/issue.yml
@@ -0,0 +1,21 @@
+# type Issue struct {
+#   ID     int64 `xorm:"pk autoincr"`
+#   RepoID int64 `xorm:"INDEX UNIQUE(repo_index)"`
+#   Index  int64 `xorm:"UNIQUE(repo_index)"` // Index in one repository.
+# }
+-
+  id: 1
+  repo_id: 1
+  index: 1
+-
+  id: 2
+  repo_id: 2
+  index: 1
+-
+  id: 3
+  repo_id: 1
+  index: 2
+-
+  id: 4
+  repo_id: 3
+  index: 1
diff --git a/models/migrations/fixtures/Test_removeInvalidLabels/issue_label.yml b/models/migrations/fixtures/Test_removeInvalidLabels/issue_label.yml
new file mode 100644
index 0000000000..5f5b8cb102
--- /dev/null
+++ b/models/migrations/fixtures/Test_removeInvalidLabels/issue_label.yml
@@ -0,0 +1,35 @@
+# type IssueLabel struct {
+#   ID      int64 `xorm:"pk autoincr"`
+#   IssueID int64 `xorm:"UNIQUE(s)"`
+#   LabelID int64 `xorm:"UNIQUE(s)"`
+# }
+-
+  id: 1 # Should remain - matches comment 2
+  issue_id: 1
+  label_id: 1
+  should_remain: true
+-
+  id: 2 # Should remain
+  issue_id: 2
+  label_id: 2
+  should_remain: true
+-
+  id: 3 # Should be deleted
+  issue_id: 1
+  label_id: 3
+  should_remain: false
+-
+  id: 4 # Should remain
+  issue_id: 3
+  label_id: 1
+  should_remain: true
+-
+  id: 5 # Should be deleted
+  issue_id: 3
+  label_id: 2
+  should_remain: false
+-
+  id: 6 # Should be deleted
+  issue_id: 3
+  label_id: 5
+  should_remain: false
diff --git a/models/migrations/fixtures/Test_removeInvalidLabels/label.yml b/models/migrations/fixtures/Test_removeInvalidLabels/label.yml
new file mode 100644
index 0000000000..094b811d91
--- /dev/null
+++ b/models/migrations/fixtures/Test_removeInvalidLabels/label.yml
@@ -0,0 +1,26 @@
+# type Label struct {
+#   ID     int64 `xorm:"pk autoincr"`
+#   RepoID int64 `xorm:"INDEX"`
+#   OrgID  int64 `xorm:"INDEX"`
+# }
+-
+  id: 1
+  repo_id: 1
+  org_id: 0
+-
+  id: 2
+  repo_id: 0
+  org_id: 1
+-
+  id: 3
+  repo_id: 2
+  org_id: 0
+-
+  id: 4
+  repo_id: 1
+  org_id: 0
+-
+  id: 5
+  repo_id: 3
+  org_id: 0
+
diff --git a/models/migrations/fixtures/Test_removeInvalidLabels/repository.yml b/models/migrations/fixtures/Test_removeInvalidLabels/repository.yml
new file mode 100644
index 0000000000..180f11b37c
--- /dev/null
+++ b/models/migrations/fixtures/Test_removeInvalidLabels/repository.yml
@@ -0,0 +1,17 @@
+# type Repository struct {
+#   ID        int64  `xorm:"pk autoincr"`
+#   OwnerID   int64  `xorm:"UNIQUE(s) index"`
+#   LowerName string `xorm:"UNIQUE(s) INDEX NOT NULL"`
+# }
+-
+  id: 1
+  owner_id: 2
+  lower_name: "repo1"
+-
+  id: 2
+  owner_id: 1
+  lower_name: "repo2"
+-
+  id: 3
+  owner_id: 2
+  lower_name: "repo3"