diff options
author | caicandong <50507092+CaiCandong@users.noreply.github.com> | 2023-07-21 16:24:36 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-07-21 16:24:36 +0800 |
commit | 840830b655a65c0763e3fd4bd0ced9256d2081a5 (patch) | |
tree | cb7ce50867f197eac04b735d57e15c45c43347b7 /models/migrations | |
parent | d57e55cd470ec737c8a9458f0ef96455e0c322ec (diff) | |
download | gitea-840830b655a65c0763e3fd4bd0ced9256d2081a5.tar.gz gitea-840830b655a65c0763e3fd4bd0ced9256d2081a5.zip |
Remove commit status running and warning to align GitHub (#25839)
Fix #25776. Close #25826.
In the discussion of #25776, @wolfogre's suggestion was to remove the
commit status of `running` and `warning` to keep it consistent with
github.
references:
-
https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#about-commit-statuses
## :warning: BREAKING :warning:
So the commit status of Gitea will be consistent with GitHub, only
`pending`, `success`, `error` and `failure`, while `warning` and
`running` are not supported anymore.
---------
Co-authored-by: Jason Song <i@wolfogre.com>
Diffstat (limited to 'models/migrations')
-rw-r--r-- | models/migrations/migrations.go | 2 | ||||
-rw-r--r-- | models/migrations/v1_21/v266.go | 26 |
2 files changed, 28 insertions, 0 deletions
diff --git a/models/migrations/migrations.go b/models/migrations/migrations.go index 9596b99c12..6599cb9cda 100644 --- a/models/migrations/migrations.go +++ b/models/migrations/migrations.go @@ -513,6 +513,8 @@ var migrations = []Migration{ NewMigration("Add branch table", v1_21.AddBranchTable), // v265 -> v266 NewMigration("Alter Actions Artifact table", v1_21.AlterActionArtifactTable), + // v266 -> v267 + NewMigration("Reduce commit status", v1_21.ReduceCommitStatus), } // GetCurrentDBVersion returns the current db version diff --git a/models/migrations/v1_21/v266.go b/models/migrations/v1_21/v266.go new file mode 100644 index 0000000000..df85286c89 --- /dev/null +++ b/models/migrations/v1_21/v266.go @@ -0,0 +1,26 @@ +// Copyright 2023 The Gitea Authors. All rights reserved. +// SPDX-License-Identifier: MIT + +package v1_21 //nolint + +import ( + "xorm.io/xorm" +) + +func ReduceCommitStatus(x *xorm.Engine) error { + sess := x.NewSession() + defer sess.Close() + + if err := sess.Begin(); err != nil { + return err + } + + if _, err := sess.Exec(`UPDATE commit_status SET state='pending' WHERE state='running'`); err != nil { + return err + } + if _, err := sess.Exec(`UPDATE commit_status SET state='failure' WHERE state='warning'`); err != nil { + return err + } + + return sess.Commit() +} |