aboutsummaryrefslogtreecommitdiffstats
path: root/models
diff options
context:
space:
mode:
authorChristian Muehlhaeuser <muesli@gmail.com>2019-07-23 20:50:39 +0200
committerzeripath <art27@cantab.net>2019-07-23 19:50:39 +0100
commit54d96c79b5b9f3d5d47aed59729ae779968fbecb (patch)
tree3d74fa2aecf3a9c5a23a1ec0c7e66fca270216aa /models
parent2f75766532fbf30883c05e93ef01c19268216c45 (diff)
downloadgitea-54d96c79b5b9f3d5d47aed59729ae779968fbecb.tar.gz
gitea-54d96c79b5b9f3d5d47aed59729ae779968fbecb.zip
Removed unnecessary conversions (#7557)
No need to convert to the same type.
Diffstat (limited to 'models')
-rw-r--r--models/action.go8
-rw-r--r--models/repo_permission.go2
2 files changed, 5 insertions, 5 deletions
diff --git a/models/action.go b/models/action.go
index a092f564bf..c819c286e2 100644
--- a/models/action.go
+++ b/models/action.go
@@ -500,7 +500,7 @@ func getIssueFromRef(repo *Repository, ref string) (*Issue, error) {
return nil, nil
}
- issue, err := GetIssueByIndex(refRepo.ID, int64(issueIndex))
+ issue, err := GetIssueByIndex(refRepo.ID, issueIndex)
if err != nil {
if IsErrIssueNotExist(err) {
return nil, nil
@@ -565,7 +565,7 @@ func UpdateIssuesCommit(doer *User, repo *Repository, commits []*PushCommit, bra
// issue is from another repo
if len(m[1]) > 0 && len(m[2]) > 0 {
- refRepo, err = GetRepositoryFromMatch(string(m[1]), string(m[2]))
+ refRepo, err = GetRepositoryFromMatch(m[1], m[2])
if err != nil {
continue
}
@@ -602,7 +602,7 @@ func UpdateIssuesCommit(doer *User, repo *Repository, commits []*PushCommit, bra
// issue is from another repo
if len(m[1]) > 0 && len(m[2]) > 0 {
- refRepo, err = GetRepositoryFromMatch(string(m[1]), string(m[2]))
+ refRepo, err = GetRepositoryFromMatch(m[1], m[2])
if err != nil {
continue
}
@@ -631,7 +631,7 @@ func UpdateIssuesCommit(doer *User, repo *Repository, commits []*PushCommit, bra
// issue is from another repo
if len(m[1]) > 0 && len(m[2]) > 0 {
- refRepo, err = GetRepositoryFromMatch(string(m[1]), string(m[2]))
+ refRepo, err = GetRepositoryFromMatch(m[1], m[2])
if err != nil {
continue
}
diff --git a/models/repo_permission.go b/models/repo_permission.go
index 25239f4dd4..916678d168 100644
--- a/models/repo_permission.go
+++ b/models/repo_permission.go
@@ -113,7 +113,7 @@ func (p *Permission) ColorFormat(s fmt.State) {
configBytes, err := unit.Config.ToDB()
config = string(configBytes)
if err != nil {
- config = string(err.Error())
+ config = err.Error()
}
}
format += "\nUnits[%d]: ID: %d RepoID: %d Type: %-v Config: %s"