diff options
| author | KN4CK3R <admin@oldschoolhack.me> | 2023-09-24 00:48:50 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-09-24 01:48:50 +0300 |
| commit | eae6985b63e332e0f6e63b3922d1eae2f4ec1108 (patch) | |
| tree | 87ca52cf184ba841c66cbea6292a7561074788fa /models | |
| parent | d8583edfe7583437e8b6b334bf666cf1beff613e (diff) | |
| download | gitea-eae6985b63e332e0f6e63b3922d1eae2f4ec1108.tar.gz gitea-eae6985b63e332e0f6e63b3922d1eae2f4ec1108.zip | |
Quote table `release` in sql queries (#27205) (#27219)
Backport of #27205
Fixes #27174
`release` is a reserved keyword in MySql. I can't reproduce the issue on
my setup and we have a test for that code but it seems there can be
setups where it fails.
Diffstat (limited to 'models')
| -rw-r--r-- | models/activities/repo_activity.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/models/activities/repo_activity.go b/models/activities/repo_activity.go index 72b6be3122..190812d592 100644 --- a/models/activities/repo_activity.go +++ b/models/activities/repo_activity.go @@ -342,7 +342,7 @@ func (stats *ActivityStats) FillReleases(repoID int64, fromTime time.Time) error // Published releases list sess := releasesForActivityStatement(repoID, fromTime) - sess.OrderBy("release.created_unix DESC") + sess.OrderBy("`release`.created_unix DESC") stats.PublishedReleases = make([]*repo_model.Release, 0) if err = sess.Find(&stats.PublishedReleases); err != nil { return err @@ -350,7 +350,7 @@ func (stats *ActivityStats) FillReleases(repoID int64, fromTime time.Time) error // Published releases authors sess = releasesForActivityStatement(repoID, fromTime) - if _, err = sess.Select("count(distinct release.publisher_id) as `count`").Table("release").Get(&count); err != nil { + if _, err = sess.Select("count(distinct `release`.publisher_id) as `count`").Table("release").Get(&count); err != nil { return err } stats.PublishedReleaseAuthorCount = count @@ -359,7 +359,7 @@ func (stats *ActivityStats) FillReleases(repoID int64, fromTime time.Time) error } func releasesForActivityStatement(repoID int64, fromTime time.Time) *xorm.Session { - return db.GetEngine(db.DefaultContext).Where("release.repo_id = ?", repoID). - And("release.is_draft = ?", false). - And("release.created_unix >= ?", fromTime.Unix()) + return db.GetEngine(db.DefaultContext).Where("`release`.repo_id = ?", repoID). + And("`release`.is_draft = ?", false). + And("`release`.created_unix >= ?", fromTime.Unix()) } |