diff options
| author | 赵智超 <1012112796@qq.com> | 2020-04-03 13:12:42 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-03 02:12:42 -0300 |
| commit | f685edf51073ac3be50ff00073a2432b4113bf82 (patch) | |
| tree | 77ce0d1aa207f9bb40b6bfc5e2810604851160b0 /models | |
| parent | 3723b0647f61717a249f2379b1fed1e6b4dbdbce (diff) | |
| download | gitea-f685edf51073ac3be50ff00073a2432b4113bf82.tar.gz gitea-f685edf51073ac3be50ff00073a2432b4113bf82.zip | |
Change review status icons on PR view style to Github style (#10737)
* change the icon of ApproveReview pr from "eye" to "check" like github
* change the icon of RejectReview pr from "x" to "request-change" like github
* add "-" after "{{" which need to be one line (TODO: may be not change all)
Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Diffstat (limited to 'models')
| -rw-r--r-- | models/review.go | 6 | ||||
| -rw-r--r-- | models/review_test.go | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/models/review.go b/models/review.go index ec28b41d35..993b5577bd 100644 --- a/models/review.go +++ b/models/review.go @@ -33,10 +33,10 @@ const ( func (rt ReviewType) Icon() string { switch rt { case ReviewTypeApprove: - return "eye" + return "check" case ReviewTypeReject: - return "x" - case ReviewTypeComment, ReviewTypeUnknown: + return "request-changes" + case ReviewTypeComment: return "comment" default: return "comment" diff --git a/models/review_test.go b/models/review_test.go index a94a65f754..4425012408 100644 --- a/models/review_test.go +++ b/models/review_test.go @@ -44,8 +44,8 @@ func TestReview_LoadCodeComments(t *testing.T) { } func TestReviewType_Icon(t *testing.T) { - assert.Equal(t, "eye", ReviewTypeApprove.Icon()) - assert.Equal(t, "x", ReviewTypeReject.Icon()) + assert.Equal(t, "check", ReviewTypeApprove.Icon()) + assert.Equal(t, "request-changes", ReviewTypeReject.Icon()) assert.Equal(t, "comment", ReviewTypeComment.Icon()) assert.Equal(t, "comment", ReviewTypeUnknown.Icon()) assert.Equal(t, "comment", ReviewType(4).Icon()) |