aboutsummaryrefslogtreecommitdiffstats
path: root/modules/git/commit.go
diff options
context:
space:
mode:
authorSebastian Weigand <s.weigand.phy@gmail.com>2025-05-16 05:56:26 +0200
committerGitHub <noreply@github.com>2025-05-15 23:56:26 -0400
commit7b518bc6c79035a53c0b752680d833fce5e1a2fe (patch)
tree89f5c803d5ceee8456b9507924496cc38b9ae9d7 /modules/git/commit.go
parentc24f4b3d2912224164ee3a75850a6a31bdd041f1 (diff)
downloadgitea-7b518bc6c79035a53c0b752680d833fce5e1a2fe.tar.gz
gitea-7b518bc6c79035a53c0b752680d833fce5e1a2fe.zip
Change "rejected" to "changes requested" in 3rd party PR review notification (#34481)
This PR changes 3rd party notifications wording on a PR review that requests changes and can be considered a follow up for #5858 to also fix #5857 in 3rd party notifications. The difference in the actual notification would be the following: ```diff - Pull request review rejected + Pull request review changes requested ``` While this is a simple string change at first look, it has a deeper UX meaning. # Motivation We could observe that some developers are hesitant to press the "Request changes" button since their peers first see that their changes were rejected, thus a more appropriate wording that also falls in line with the meaning and UI would be beneficial. ## Meaning Pressing the `Request changes` button in a PR review means that as a reviewer you are willing to merge the general change in a PR if changes requested review comments are implemented. Rejecting a PR on the other hand would be equivalent with closing it since that change isn't welcome at all (e.g. out of scope feature). ## Sync with UI The UI button says `request changes` and the other options ![image](https://github.com/user-attachments/assets/3766cc89-40d7-4c5e-9ff7-a0e1f6991ea6) ## Considered Problems This might break some automation for users who rely on string matching.
Diffstat (limited to 'modules/git/commit.go')
0 files changed, 0 insertions, 0 deletions