diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2024-03-06 19:50:39 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-06 11:50:39 +0000 |
| commit | 90a3f2d4b7ed3890d9655c0334444f86d89b7b30 (patch) | |
| tree | 83d3d0b0c9a4728edf43f80a43d4309d1b9eb5f3 /modules/git/commit_test.go | |
| parent | c381343a60b9c9eedb9dbc0931d1b87cb3c1f366 (diff) | |
| download | gitea-90a3f2d4b7ed3890d9655c0334444f86d89b7b30.tar.gz gitea-90a3f2d4b7ed3890d9655c0334444f86d89b7b30.zip | |
Avoid unexpected panic in graceful manager (#29629)
There is a fundamental design problem of the "manager" and the "wait
group".
If nothing has started, the "Wait" just panics: sync: WaitGroup is
reused before previous Wait has returned
There is no clear solution besides a complete rewriting of the "manager"
If there are some mistakes in the app.ini, end users would just see the
"panic", but not the real error messages. A real case: #27643
This PR is just a quick fix for the annoying panic problem.
Diffstat (limited to 'modules/git/commit_test.go')
0 files changed, 0 insertions, 0 deletions