diff options
| author | Jonathan Tran <jon@allspice.io> | 2023-03-05 16:59:05 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-05 22:59:05 +0100 |
| commit | 4de80392bc19628091c6b77cca9a82c00b9bd834 (patch) | |
| tree | ab22850fbd8cf767828f43ff6028d298139fb875 /modules/markup/html.go | |
| parent | ea7f0d6fcfe9567cac8151536b36450de8645e88 (diff) | |
| download | gitea-4de80392bc19628091c6b77cca9a82c00b9bd834.tar.gz gitea-4de80392bc19628091c6b77cca9a82c00b9bd834.zip | |
Add context when rendering labels or emojis (#23281)
This branch continues the work of #23092 and attempts to rid the
codebase of any `nil` contexts when using a `RenderContext`.
Anything that renders markdown or does post processing may call
`markup.sha1CurrentPatternProcessor()`, and this runs
`git.OpenRepository()`, which needs a context. It will panic if the
context is `nil`. This branch attempts to _always_ include a context
when creating a `RenderContext` to prevent future crashes.
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Diffstat (limited to 'modules/markup/html.go')
| -rw-r--r-- | modules/markup/html.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/modules/markup/html.go b/modules/markup/html.go index bcb38f99eb..76fc54cf46 100644 --- a/modules/markup/html.go +++ b/modules/markup/html.go @@ -291,9 +291,10 @@ func RenderDescriptionHTML( // RenderEmoji for when we want to just process emoji and shortcodes // in various places it isn't already run through the normal markdown processor func RenderEmoji( + ctx *RenderContext, content string, ) (string, error) { - return renderProcessString(&RenderContext{}, emojiProcessors, content) + return renderProcessString(ctx, emojiProcessors, content) } var ( |