diff options
author | Lunny Xiao <xiaolunwen@gmail.com> | 2019-05-31 04:26:57 +0800 |
---|---|---|
committer | techknowlogick <techknowlogick@gitea.io> | 2019-05-30 16:26:57 -0400 |
commit | 7d12ec2abd452c6a8a5981537ce2c50440979e25 (patch) | |
tree | 450db74a634c633b4278890a9b1c389d1421689a /modules/migrations/migrate.go | |
parent | 43cf2f3b55de4a69183966da2a6e0167592c733c (diff) | |
download | gitea-7d12ec2abd452c6a8a5981537ce2c50440979e25.tar.gz gitea-7d12ec2abd452c6a8a5981537ce2c50440979e25.zip |
improve github downloader on migrations (#7049)
* improve github downloader on migrations
* fix tests
* fix uppercase function parameters
Diffstat (limited to 'modules/migrations/migrate.go')
-rw-r--r-- | modules/migrations/migrate.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/modules/migrations/migrate.go b/modules/migrations/migrate.go index ac55a2e727..4b1229f949 100644 --- a/modules/migrations/migrate.go +++ b/modules/migrations/migrate.go @@ -128,8 +128,8 @@ func migrateRepository(downloader base.Downloader, uploader base.Uploader, opts if opts.Issues { log.Trace("migrating issues and comments") - for { - issues, err := downloader.GetIssues(0, 100) + for i := 1; ; i++ { + issues, isEnd, err := downloader.GetIssues(i, 100) if err != nil { return err } @@ -160,7 +160,7 @@ func migrateRepository(downloader base.Downloader, uploader base.Uploader, opts } } - if len(issues) < 100 { + if isEnd { break } } @@ -168,8 +168,8 @@ func migrateRepository(downloader base.Downloader, uploader base.Uploader, opts if opts.PullRequests { log.Trace("migrating pull requests and comments") - for { - prs, err := downloader.GetPullRequests(0, 100) + for i := 1; ; i++ { + prs, err := downloader.GetPullRequests(i, 100) if err != nil { return err } |