diff options
author | TheFox0x7 <thefox0x7@gmail.com> | 2024-12-15 11:41:29 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-12-15 10:41:29 +0000 |
commit | 33e8e82c4b528db8efb1cf9fc4dbab2d9e21ace8 (patch) | |
tree | 6ee296e2ef469911d0db440100e1eb835945af89 /modules/queue | |
parent | df9a78cd04e364264c103cf3a92d94179cc1dd4f (diff) | |
download | gitea-33e8e82c4b528db8efb1cf9fc4dbab2d9e21ace8.tar.gz gitea-33e8e82c4b528db8efb1cf9fc4dbab2d9e21ace8.zip |
Enable tenv and testifylint rules (#32852)
Enables tenv and testifylint linters
closes: https://github.com/go-gitea/gitea/issues/32842
Diffstat (limited to 'modules/queue')
-rw-r--r-- | modules/queue/base_test.go | 6 | ||||
-rw-r--r-- | modules/queue/workerqueue_test.go | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/modules/queue/base_test.go b/modules/queue/base_test.go index c5bf526ae6..01b52b3c16 100644 --- a/modules/queue/base_test.go +++ b/modules/queue/base_test.go @@ -46,10 +46,10 @@ func testQueueBasic(t *testing.T, newFn func(cfg *BaseConfig) (baseQueue, error) assert.NoError(t, err) if !isUnique { assert.EqualValues(t, 2, cnt) - assert.EqualValues(t, false, has) // non-unique queues don't check for duplicates + assert.False(t, has) // non-unique queues don't check for duplicates } else { assert.EqualValues(t, 1, cnt) - assert.EqualValues(t, true, has) + assert.True(t, has) } // push another item @@ -101,7 +101,7 @@ func testQueueBasic(t *testing.T, newFn func(cfg *BaseConfig) (baseQueue, error) pushBlockTime = 30 * time.Millisecond err = q.PushItem(ctx, []byte("item-full")) assert.ErrorIs(t, err, context.DeadlineExceeded) - assert.True(t, time.Since(timeStart) >= pushBlockTime*2/3) + assert.GreaterOrEqual(t, time.Since(timeStart), pushBlockTime*2/3) pushBlockTime = oldPushBlockTime // remove all diff --git a/modules/queue/workerqueue_test.go b/modules/queue/workerqueue_test.go index d66253ff66..c0841a1752 100644 --- a/modules/queue/workerqueue_test.go +++ b/modules/queue/workerqueue_test.go @@ -172,8 +172,8 @@ func testWorkerPoolQueuePersistence(t *testing.T, queueSetting setting.QueueSett q2() // restart the queue to continue to execute the tasks in it - assert.NotZero(t, len(tasksQ1)) - assert.NotZero(t, len(tasksQ2)) + assert.NotEmpty(t, tasksQ1) + assert.NotEmpty(t, tasksQ2) assert.EqualValues(t, testCount, len(tasksQ1)+len(tasksQ2)) } |