aboutsummaryrefslogtreecommitdiffstats
path: root/modules/storage
diff options
context:
space:
mode:
authorzeripath <art27@cantab.net>2021-07-15 16:46:07 +0100
committerGitHub <noreply@github.com>2021-07-15 11:46:07 -0400
commit33a8eec33e975a74f1718a83e99eb6abc7662a19 (patch)
treed000ff3f37d417e9d03d15d070ed6fecf9c56636 /modules/storage
parentaed086f8b021f5724ff1449ceb9f44dc28749a97 (diff)
downloadgitea-33a8eec33e975a74f1718a83e99eb6abc7662a19.tar.gz
gitea-33a8eec33e975a74f1718a83e99eb6abc7662a19.zip
Retry rename on lock induced failures (#16435)
* Retry rename on lock induced failures Due to external locking on Windows it is possible for an os.Rename to fail if the files or directories are being used elsewhere. This PR simply suggests retrying the rename again similar to how we handle the os.Remove problems. Fix #16427 Signed-off-by: Andrew Thornton <art27@cantab.net> * resolve CI fail Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Diffstat (limited to 'modules/storage')
-rw-r--r--modules/storage/local.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/storage/local.go b/modules/storage/local.go
index 46e5d60e6b..1329f722c2 100644
--- a/modules/storage/local.go
+++ b/modules/storage/local.go
@@ -96,7 +96,7 @@ func (l *LocalStorage) Save(path string, r io.Reader, size int64) (int64, error)
return 0, err
}
- if err := os.Rename(tmp.Name(), p); err != nil {
+ if err := util.Rename(tmp.Name(), p); err != nil {
return 0, err
}