diff options
author | Giteabot <teabot@gitea.io> | 2024-07-31 23:06:37 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-07-31 23:06:37 +0800 |
commit | 6203ae764a15b6d23125d616c9b72d9c940a301c (patch) | |
tree | 7392ebead3cbd6dd952c8093848e5cd74df1ff32 /package.json | |
parent | 8591c918f6a70366667ec5a928effbec10c65cc3 (diff) | |
download | gitea-6203ae764a15b6d23125d616c9b72d9c940a301c.tar.gz gitea-6203ae764a15b6d23125d616c9b72d9c940a301c.zip |
Distinguish LFS object errors to ignore missing objects during migration (#31702) (#31745)
Backport #31702 by @wolfogre
Fix #31137.
Replace #31623 #31697.
When migrating LFS objects, if there's any object that failed (like some
objects are losted, which is not really critical), Gitea will stop
migrating LFS immediately but treat the migration as successful.
This PR checks the error according to the [LFS api
doc](https://github.com/git-lfs/git-lfs/blob/main/docs/api/batch.md#successful-responses).
> LFS object error codes should match HTTP status codes where possible:
>
> - 404 - The object does not exist on the server.
> - 409 - The specified hash algorithm disagrees with the server's
acceptable options.
> - 410 - The object was removed by the owner.
> - 422 - Validation error.
If the error is `404`, it's safe to ignore it and continue migration.
Otherwise, stop the migration and mark it as failed to ensure data
integrity of LFS objects.
And maybe we should also ignore others errors (maybe `410`? I'm not sure
what's the difference between "does not exist" and "removed by the
owner".), we can add it later when some users report that they have
failed to migrate LFS because of an error which should be ignored.
Co-authored-by: Jason Song <i@wolfogre.com>
Diffstat (limited to 'package.json')
0 files changed, 0 insertions, 0 deletions