diff options
| author | silverwind <me@silverwind.io> | 2024-04-22 13:48:42 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-22 11:48:42 +0000 |
| commit | 74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2 (patch) | |
| tree | 94b0356bea5ad1cd24a523947cf001509a973be1 /routers/api/packages/conda | |
| parent | aff7b7bdd285cc1fcabea774f153886e11ae9f5d (diff) | |
| download | gitea-74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2.tar.gz gitea-74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2.zip | |
Enable more `revive` linter rules (#30608)
Noteable additions:
- `redefines-builtin-id` forbid variable names that shadow go builtins
- `empty-lines` remove unnecessary empty lines that `gofumpt` does not
remove for some reason
- `superfluous-else` eliminate more superfluous `else` branches
Rules are also sorted alphabetically and I cleaned up various parts of
`.golangci.yml`.
Diffstat (limited to 'routers/api/packages/conda')
| -rw-r--r-- | routers/api/packages/conda/conda.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/routers/api/packages/conda/conda.go b/routers/api/packages/conda/conda.go index 30c80fc15e..c7e4544d52 100644 --- a/routers/api/packages/conda/conda.go +++ b/routers/api/packages/conda/conda.go @@ -174,12 +174,12 @@ func EnumeratePackages(ctx *context.Context) { } func UploadPackageFile(ctx *context.Context) { - upload, close, err := ctx.UploadStream() + upload, needToClose, err := ctx.UploadStream() if err != nil { apiError(ctx, http.StatusInternalServerError, err) return } - if close { + if needToClose { defer upload.Close() } |