diff options
| author | zeripath <art27@cantab.net> | 2021-05-04 22:48:31 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-04 22:48:31 +0100 |
| commit | 47fd1569361a4cb474aa760cefa76c1158c5d944 (patch) | |
| tree | eb8483b1bd146938cd89b271087b1bdef004b76e /routers/api/v1/api.go | |
| parent | ab77a24f18ae45248bd6c71778fe3bfacacf864f (diff) | |
| download | gitea-47fd1569361a4cb474aa760cefa76c1158c5d944.tar.gz gitea-47fd1569361a4cb474aa760cefa76c1158c5d944.zip | |
Use route rather than use thus reducing the number of stack frames (#15301)
Since the move to Chi the number of stack frames has proliferated somewhat catastrophically and we're up to 96 frames with multiple tests of the url outside of a trie which is inefficient.
This PR reduces the number of stack frames by 6 through careful use of Route, moves Captcha into its own router so that it only fires on Captcha routes, similarly for avatars and repo-avatars.
The robots.txt, / and apple-touch-icon.png are moved out of requiring Contexter.
It moves access logger higher in the stack frame because there is no reason why it can't be higher.
Extract from #15186
Contains #15292
Diffstat (limited to 'routers/api/v1/api.go')
| -rw-r--r-- | routers/api/v1/api.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go index ecb3a3f03d..05b95d6d5f 100644 --- a/routers/api/v1/api.go +++ b/routers/api/v1/api.go @@ -572,10 +572,6 @@ func Routes() *web.Route { } m.Use(context.APIContexter()) - if setting.EnableAccessLog { - m.Use(context.AccessLogger()) - } - m.Use(context.ToggleAPI(&context.ToggleOptions{ SignInRequired: setting.Service.RequireSignInView, })) |