diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2024-12-24 21:47:45 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-24 13:47:45 +0000 |
| commit | 2a828e2798d5f77e768e1199d88a00996bd3e45a (patch) | |
| tree | 2073e3384d41675feae64dd38e79168ae25b8a33 /routers/api/v1/repo/notes.go | |
| parent | b8b690feb958dffb51eb1d5fc86c16996ba830e1 (diff) | |
| download | gitea-2a828e2798d5f77e768e1199d88a00996bd3e45a.tar.gz gitea-2a828e2798d5f77e768e1199d88a00996bd3e45a.zip | |
Clarify path param naming (#32969)
In history (from some legacy frameworks), both `:name` and `name` are
supported as path path name, `:name` is an alias to `name`.
To make code consistent, now we should only use `name` but not `:name`.
Also added panic check in related functions to make sure the name won't
be abused in case some downstreams still use them.
Diffstat (limited to 'routers/api/v1/repo/notes.go')
| -rw-r--r-- | routers/api/v1/repo/notes.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/routers/api/v1/repo/notes.go b/routers/api/v1/repo/notes.go index 8689d25e15..8fec844cc4 100644 --- a/routers/api/v1/repo/notes.go +++ b/routers/api/v1/repo/notes.go @@ -52,7 +52,7 @@ func GetNote(ctx *context.APIContext) { // "404": // "$ref": "#/responses/notFound" - sha := ctx.PathParam(":sha") + sha := ctx.PathParam("sha") if !git.IsValidRefPattern(sha) { ctx.Error(http.StatusUnprocessableEntity, "no valid ref or sha", fmt.Sprintf("no valid ref or sha: %s", sha)) return |