diff options
| author | Lunny Xiao <xiaolunwen@gmail.com> | 2024-12-29 19:30:01 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-30 03:30:01 +0000 |
| commit | f4ccbd38dca77b1515a08ddf927f4f20cf644d30 (patch) | |
| tree | 2c8f4ac93fa1673a66afc498c141bcc070cca3a4 /routers/api/v1 | |
| parent | 344c89ea34bda1ac7382f8cba210ee325e07597e (diff) | |
| download | gitea-f4ccbd38dca77b1515a08ddf927f4f20cf644d30.tar.gz gitea-f4ccbd38dca77b1515a08ddf927f4f20cf644d30.zip | |
Use gitrepo.GetTreePathLatestCommit to get file lastest commit instead from latest commit cache (#32987)
The latest commit cache is currently used only for listing tree files.
However, a cold start may take longer than directly invoking the Git
command. This PR addresses the issue of slow response times when
accessing raw files, improving performance in such scenarios.
```log
gitea.log:105521:2024/12/23 08:22:18 ...eb/routing/logger.go:68:func1() [W] router: slow GET /xxxx/xxxxxx/raw/commit/xxxxxxxxxxxxxxxxxxxxxxxxxxx/.editorconfig for 172.18.0.5:53252, elapsed 3526.8ms @ repo/download.go:117(repo.SingleDownload)
```
Diffstat (limited to 'routers/api/v1')
| -rw-r--r-- | routers/api/v1/repo/file.go | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/routers/api/v1/repo/file.go b/routers/api/v1/repo/file.go index 6591b9a752..8a4f78a3d7 100644 --- a/routers/api/v1/repo/file.go +++ b/routers/api/v1/repo/file.go @@ -11,7 +11,6 @@ import ( "fmt" "io" "net/http" - "path" "strings" "time" @@ -242,19 +241,14 @@ func getBlobForEntry(ctx *context.APIContext) (blob *git.Blob, entry *git.TreeEn return nil, nil, nil } - info, _, err := git.Entries([]*git.TreeEntry{entry}).GetCommitsInfo(ctx, ctx.Repo.Commit, path.Dir("/" + ctx.Repo.TreePath)[1:]) + latestCommit, err := ctx.Repo.GitRepo.GetTreePathLatestCommit(ctx.Repo.Commit.ID.String(), ctx.Repo.TreePath) if err != nil { - ctx.Error(http.StatusInternalServerError, "GetCommitsInfo", err) + ctx.Error(http.StatusInternalServerError, "GetTreePathLatestCommit", err) return nil, nil, nil } + when := &latestCommit.Committer.When - if len(info) == 1 { - // Not Modified - lastModified = &info[0].Commit.Committer.When - } - blob = entry.Blob() - - return blob, entry, lastModified + return entry.Blob(), entry, when } // GetArchive get archive of a repository |