diff options
| author | silverwind <me@silverwind.io> | 2024-04-22 13:48:42 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-22 11:48:42 +0000 |
| commit | 74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2 (patch) | |
| tree | 94b0356bea5ad1cd24a523947cf001509a973be1 /routers/web/repo/pull_review.go | |
| parent | aff7b7bdd285cc1fcabea774f153886e11ae9f5d (diff) | |
| download | gitea-74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2.tar.gz gitea-74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2.zip | |
Enable more `revive` linter rules (#30608)
Noteable additions:
- `redefines-builtin-id` forbid variable names that shadow go builtins
- `empty-lines` remove unnecessary empty lines that `gofumpt` does not
remove for some reason
- `superfluous-else` eliminate more superfluous `else` branches
Rules are also sorted alphabetically and I cleaned up various parts of
`.golangci.yml`.
Diffstat (limited to 'routers/web/repo/pull_review.go')
| -rw-r--r-- | routers/web/repo/pull_review.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/routers/web/repo/pull_review.go b/routers/web/repo/pull_review.go index c8d149a482..a65d4866d0 100644 --- a/routers/web/repo/pull_review.go +++ b/routers/web/repo/pull_review.go @@ -318,7 +318,6 @@ func UpdateViewedFiles(ctx *context.Context) { updatedFiles := make(map[string]pull_model.ViewedState, len(data.Files)) for file, viewed := range data.Files { - // Only unviewed and viewed are possible, has-changed can not be set from the outside state := pull_model.Unviewed if viewed { |