diff options
| author | Nanguan Lin <70063547+lng2020@users.noreply.github.com> | 2023-10-11 19:02:24 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-11 11:02:24 +0000 |
| commit | dc04044716088e3786497e200abe1fdfb3a943b6 (patch) | |
| tree | 45230f2067cbf0f130042e33eed36a38ed69e9b1 /services/pull | |
| parent | dca195e9bd0d14a5cf888524e51175da8ab24588 (diff) | |
| download | gitea-dc04044716088e3786497e200abe1fdfb3a943b6.tar.gz gitea-dc04044716088e3786497e200abe1fdfb3a943b6.zip | |
Replace assert.Fail with assert.FailNow (#27578)
assert.Fail() will continue to execute the code while assert.FailNow()
not. I thought those uses of assert.Fail() should exit immediately.
PS: perhaps it's a good idea to use
[require](https://pkg.go.dev/github.com/stretchr/testify/require)
somewhere because the assert package's default behavior does not exit
when an error occurs, which makes it difficult to find the root error
reason.
Diffstat (limited to 'services/pull')
| -rw-r--r-- | services/pull/check_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/pull/check_test.go b/services/pull/check_test.go index 4a99859f5a..dcf5f7b93a 100644 --- a/services/pull/check_test.go +++ b/services/pull/check_test.go @@ -54,7 +54,7 @@ func TestPullRequest_AddToTaskQueue(t *testing.T) { case id := <-idChan: assert.EqualValues(t, pr.ID, id) case <-time.After(time.Second): - assert.Fail(t, "Timeout: nothing was added to pullRequestQueue") + assert.FailNow(t, "Timeout: nothing was added to pullRequestQueue") } has, err = prPatchCheckerQueue.Has(strconv.FormatInt(pr.ID, 10)) |