diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2024-04-20 11:15:04 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-20 03:15:04 +0000 |
| commit | 48d4580dd5e975de2e8207bb9b9a2f258711d38c (patch) | |
| tree | 4a2fbca0b792b37f09014952a7325bbb09e7ac97 /services/repository/transfer_test.go | |
| parent | 89e39872fff39797107acafb984dc2dc3ec3dd6a (diff) | |
| download | gitea-48d4580dd5e975de2e8207bb9b9a2f258711d38c.tar.gz gitea-48d4580dd5e975de2e8207bb9b9a2f258711d38c.zip | |
Clarify permission "HasAccess" behavior (#30585)
Follow #30495
"HasAccess" behavior wasn't clear, to make it clear:
* Use a new name `HasAnyUnitAccess`, it will be easier to review related
code and permission problems.
* Separate everyone access mode to a separate field, then all calls to
HasAccess are reverted to old behavior before #30495.
* Add new tests.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'services/repository/transfer_test.go')
| -rw-r--r-- | services/repository/transfer_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/services/repository/transfer_test.go b/services/repository/transfer_test.go index c3f03d6638..67799eddcc 100644 --- a/services/repository/transfer_test.go +++ b/services/repository/transfer_test.go @@ -67,13 +67,13 @@ func TestStartRepositoryTransferSetPermission(t *testing.T) { repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3}) repo.Owner = unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}) - hasAccess, err := access_model.HasAccess(db.DefaultContext, recipient.ID, repo) + hasAccess, err := access_model.HasAnyUnitAccess(db.DefaultContext, recipient.ID, repo) assert.NoError(t, err) assert.False(t, hasAccess) assert.NoError(t, StartRepositoryTransfer(db.DefaultContext, doer, recipient, repo, nil)) - hasAccess, err = access_model.HasAccess(db.DefaultContext, recipient.ID, repo) + hasAccess, err = access_model.HasAnyUnitAccess(db.DefaultContext, recipient.ID, repo) assert.NoError(t, err) assert.True(t, hasAccess) |