diff options
| author | TheFox0x7 <thefox0x7@gmail.com> | 2025-01-09 02:21:47 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-09 09:21:47 +0800 |
| commit | 2a02734f93c0091275c77e370b7eed03b2c5f18e (patch) | |
| tree | 2dcad43764cbfa254f7c6d355f5a14ffdcdb109a /services/wiki | |
| parent | fa9191b7b9373666f30a55bbc63b932833bceefe (diff) | |
| download | gitea-2a02734f93c0091275c77e370b7eed03b2c5f18e.tar.gz gitea-2a02734f93c0091275c77e370b7eed03b2c5f18e.zip | |
Refactor older tests to use testify (#33140)
Refactor checks to use assert/require
Use require.Eventually for waiting in elastic and meilisearch tests
Use require to exit early instead of assert
Diffstat (limited to 'services/wiki')
| -rw-r--r-- | services/wiki/wiki_test.go | 21 |
1 files changed, 9 insertions, 12 deletions
diff --git a/services/wiki/wiki_test.go b/services/wiki/wiki_test.go index 0a18cffa25..e8b89f5e97 100644 --- a/services/wiki/wiki_test.go +++ b/services/wiki/wiki_test.go @@ -17,6 +17,7 @@ import ( _ "code.gitea.io/gitea/models/actions" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" ) func TestMain(m *testing.M) { @@ -166,9 +167,8 @@ func TestRepository_AddWikiPage(t *testing.T) { assert.NoError(t, AddWikiPage(git.DefaultContext, doer, repo, webPath, wikiContent, commitMsg)) // Now need to show that the page has been added: gitRepo, err := gitrepo.OpenWikiRepository(git.DefaultContext, repo) - if !assert.NoError(t, err) { - return - } + require.NoError(t, err) + defer gitRepo.Close() masterTree, err := gitRepo.GetTree(repo.DefaultWikiBranch) assert.NoError(t, err) @@ -238,9 +238,8 @@ func TestRepository_DeleteWikiPage(t *testing.T) { // Now need to show that the page has been added: gitRepo, err := gitrepo.OpenWikiRepository(git.DefaultContext, repo) - if !assert.NoError(t, err) { - return - } + require.NoError(t, err) + defer gitRepo.Close() masterTree, err := gitRepo.GetTree(repo.DefaultWikiBranch) assert.NoError(t, err) @@ -253,9 +252,8 @@ func TestPrepareWikiFileName(t *testing.T) { unittest.PrepareTestEnv(t) repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1}) gitRepo, err := gitrepo.OpenWikiRepository(git.DefaultContext, repo) - if !assert.NoError(t, err) { - return - } + require.NoError(t, err) + defer gitRepo.Close() tests := []struct { @@ -307,9 +305,8 @@ func TestPrepareWikiFileName_FirstPage(t *testing.T) { assert.NoError(t, err) gitRepo, err := git.OpenRepository(git.DefaultContext, tmpDir) - if !assert.NoError(t, err) { - return - } + require.NoError(t, err) + defer gitRepo.Close() existence, newWikiPath, err := prepareGitPath(gitRepo, "master", "Home") |