aboutsummaryrefslogtreecommitdiffstats
path: root/services
diff options
context:
space:
mode:
authorChongyi Zheng <git@zcy.dev>2023-08-28 12:43:16 -0400
committerGitHub <noreply@github.com>2023-08-29 00:43:16 +0800
commitac2f8c9ac66a15a9e1799da3e8436928aeada53e (patch)
treee64e64555771df9849d9a6c8b7094cdcc08191a7 /services
parent4803766f7a5d1ca86a1e62949dcd9a9ff8d0f64c (diff)
downloadgitea-ac2f8c9ac66a15a9e1799da3e8436928aeada53e.tar.gz
gitea-ac2f8c9ac66a15a9e1799da3e8436928aeada53e.zip
Reduce some allocations in type conversion (#26772)
Diffstat (limited to 'services')
-rw-r--r--services/packages/rpm/repository.go2
-rw-r--r--services/pull/pull.go4
2 files changed, 3 insertions, 3 deletions
diff --git a/services/packages/rpm/repository.go b/services/packages/rpm/repository.go
index 774613509e..cfd70ec23e 100644
--- a/services/packages/rpm/repository.go
+++ b/services/packages/rpm/repository.go
@@ -232,7 +232,7 @@ func buildRepomd(pv *packages_model.PackageVersion, ownerID int64, data []*repoD
}
var buf bytes.Buffer
- buf.Write([]byte(xml.Header))
+ buf.WriteString(xml.Header)
if err := xml.NewEncoder(&buf).Encode(&Repomd{
Xmlns: "http://linux.duke.edu/metadata/repo",
XmlnsRpm: "http://linux.duke.edu/metadata/rpm",
diff --git a/services/pull/pull.go b/services/pull/pull.go
index 0b6194b143..d4352abafe 100644
--- a/services/pull/pull.go
+++ b/services/pull/pull.go
@@ -755,11 +755,11 @@ func GetSquashMergeCommitMessages(ctx context.Context, pr *issues_model.PullRequ
}
for _, author := range authors {
- if _, err := stringBuilder.Write([]byte("Co-authored-by: ")); err != nil {
+ if _, err := stringBuilder.WriteString("Co-authored-by: "); err != nil {
log.Error("Unable to write to string builder Error: %v", err)
return ""
}
- if _, err := stringBuilder.Write([]byte(author)); err != nil {
+ if _, err := stringBuilder.WriteString(author); err != nil {
log.Error("Unable to write to string builder Error: %v", err)
return ""
}