diff options
author | Yarden Shoham <git@yardenshoham.com> | 2024-03-08 11:30:41 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-03-08 09:30:41 +0000 |
commit | b5c418f271963f8de0b8324305ea74cde7d3f3ab (patch) | |
tree | c2e7daffb22aedaa20139135a027f5b7b0cf3bd4 /services | |
parent | 9dc8a6336edddca0f3f90392bbc398f4ceaeaf13 (diff) | |
download | gitea-b5c418f271963f8de0b8324305ea74cde7d3f3ab.tar.gz gitea-b5c418f271963f8de0b8324305ea74cde7d3f3ab.zip |
Don't use `<br />` in alert block (#29650)
- Follows https://github.com/go-gitea/gitea/pull/29121
When I implemented alert blocks I was always testing the markdown in
issue comments. I used `<br />` for line breaks and it looked good. I
have since learned that the markdown on README files doesn't allow these
tags. So a comment with
```md
> [!NOTE]
> If you're interested in using our APIs, we have experimental support with [documentation](https://try.gitea.io/api/swagger).
```
looked like this in a comment
![image](https://github.com/go-gitea/gitea/assets/20454870/96b1de01-2c87-4d4f-83dd-98192b83e9d0)
but looked like this in a README
![image](https://github.com/go-gitea/gitea/assets/20454870/474b636d-dd7a-4b7f-ba27-643803c71aa3)
So I changed how we render the alert block by having the alert itself
have a dedicated paragraph, so line breaks happen naturally between
paragraphs.
# Before
![image](https://github.com/go-gitea/gitea/assets/20454870/474b636d-dd7a-4b7f-ba27-643803c71aa3)
![image](https://github.com/go-gitea/gitea/assets/20454870/167a8d37-9a44-4479-9340-5dc80347b595)
# After
![image](https://github.com/go-gitea/gitea/assets/20454870/2f99fec0-98ff-4ba8-97fe-b4567041ae79)
![image](https://github.com/go-gitea/gitea/assets/20454870/ffdeae11-fb06-4d00-b497-eae135f0d7ad)
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'services')
0 files changed, 0 insertions, 0 deletions