diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-02-11 14:34:11 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-11 14:34:11 +0800 |
| commit | e9288c24773157411edec17c9bbcc8c1567e91ee (patch) | |
| tree | b34c730a13ab9a56d14b0fcccf1e136ca0233b68 /services | |
| parent | 1cb8d14bf71e0b8637c9eaa10808b4fd05139f45 (diff) | |
| download | gitea-e9288c24773157411edec17c9bbcc8c1567e91ee.tar.gz gitea-e9288c24773157411edec17c9bbcc8c1567e91ee.zip | |
Fix improper HTMLURL usages in Go code (#22839)
In Go code, HTMLURL should be only used for external systems, like
API/webhook/mail/notification, etc.
If a URL is used by `Redirect` or rendered in a template, it should be a
relative URL (aka `Link()` in Gitea)
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'services')
| -rw-r--r-- | services/actions/commit_status.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/actions/commit_status.go b/services/actions/commit_status.go index c17f8ef153..efb5ec6d44 100644 --- a/services/actions/commit_status.go +++ b/services/actions/commit_status.go @@ -59,7 +59,7 @@ func CreateCommitStatus(ctx context.Context, job *actions_model.ActionRunJob) er Creator: creator, CommitStatus: &git_model.CommitStatus{ SHA: sha, - TargetURL: run.HTMLURL(), + TargetURL: run.Link(), Description: "", Context: ctxname, CreatorID: payload.Pusher.ID, |