Refactor project templates (#26448)

This PR refactors a bunch of projects-related code, mostly the
templates.
The following things were done:
  - rename boards to columns in frontend code
  - use the new `ctx.Locale.Tr` method
  - cleanup template, remove useless newlines, classes, comments
  - merge org-/user and repo level project template together
    - move "new column" button into project toolbar
- move issue card (shared by projects and pinned issues) to shared
template, remove useless duplicated styles
- add search function to projects (to make the layout more similar to
milestones list where it is inherited from :laughing:)
  - maybe more changes I forgot I've done :laughing: 

Closes #24893

After:
![Bildschirmfoto vom 2023-08-10
23-02-00](https://github.com/go-gitea/gitea/assets/47871822/cab61456-1d23-4373-8163-e567f1b3b5f9)
![Bildschirmfoto vom 2023-08-10
23-02-26](https://github.com/go-gitea/gitea/assets/47871822/94b55d60-5572-48eb-8111-538a52d8bcc6)
![Bildschirmfoto vom 2023-08-10
23-02-46](https://github.com/go-gitea/gitea/assets/47871822/a0358f4b-4e05-4194-a7bc-6e0ecba5a9b6)

---------

Co-authored-by: silverwind <me@silverwind.io>

1 files changed, 131 insertions, 202 deletions

diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl
index fe4ea6022f..97869ca262 100644
--- a/templates/projects/view.tmpl
+++ b/templates/projects/view.tmpl
@@ -1,25 +1,48 @@
-<div class="ui two column stackable grid">
-	<div class="column">
-	</div>
-	<div class="column right aligned">
-		{{if .CanWriteProjects}}
-			<a class="ui small green button show-modal item" data-modal="#new-board-item">{{.locale.Tr "new_project_column"}}</a>
-		{{end}}
-		<div class="ui small modal new-board-modal" id="new-board-item">
+{{$canWriteProject := and .CanWriteProjects (or (not .Repository) (not .Repository.IsArchived))}}
+
+<div class="gt-df gt-sb gt-ac gt-mb-4">
+	<h2 class="gt-mb-0">{{.Project.Title}}</h2>
+	{{if $canWriteProject}}
+		<div class="ui compact mini menu">
+			<a class="item" href="{{.Link}}/edit?redirect=project">
+				{{svg "octicon-pencil"}}
+				{{ctx.Locale.Tr "repo.issues.label_edit"}}
+			</a>
+			{{if .Project.IsClosed}}
+				<button class="item btn link-action" data-url="{{.Link}}/open">
+					{{svg "octicon-check"}}
+					{{ctx.Locale.Tr "repo.projects.open"}}
+				</button>
+			{{else}}
+				<button class="item btn link-action" data-url="{{.Link}}/close">
+					{{svg "octicon-skip"}}
+					{{ctx.Locale.Tr "repo.projects.close"}}
+				</button>
+			{{end}}
+			<button class="item btn delete-button" data-url="{{.Link}}/delete" data-id="{{.Project.ID}}">
+				{{svg "octicon-trash"}}
+				{{ctx.Locale.Tr "repo.issues.label_delete"}}
+			</button>
+			<button class="item btn show-modal" data-modal="#new-project-column-item">
+				{{svg "octicon-plus"}}
+				{{ctx.Locale.Tr "new_project_column"}}
+			</button>
+		</div>
+		<div class="ui small modal new-project-column-modal" id="new-project-column-item">
 			<div class="header">
-				{{$.locale.Tr "repo.projects.column.new"}}
+				{{ctx.Locale.Tr "repo.projects.column.new"}}
 			</div>
 			<div class="content">
 				<form class="ui form">
 					<div class="required field">
-						<label for="new_board">{{$.locale.Tr "repo.projects.column.new_title"}}</label>
-						<input class="new-board" id="new_board" name="title" required>
+						<label for="new_project_column">{{ctx.Locale.Tr "repo.projects.column.new_title"}}</label>
+						<input class="new-project-column" id="new_project_column" name="title" required>
 					</div>
 
 					<div class="field color-field">
-						<label for="new_board_color">{{$.locale.Tr "repo.projects.column.color"}}</label>
+						<label for="new_project_column_color">{{ctx.Locale.Tr "repo.projects.column.color"}}</label>
 						<div class="color picker column">
-							<input class="color-picker" maxlength="7" placeholder="#c320f6" id="new_board_color_picker" name="color">
+							<input class="color-picker" maxlength="7" placeholder="#c320f6" id="new_project_column_color_picker" name="color">
 							<div class="column precolors">
 								{{template "repo/issue/label_precolors"}}
 							</div>
@@ -27,237 +50,143 @@
 					</div>
 
 					<div class="text right actions">
-						<button class="ui cancel button">{{$.locale.Tr "settings.cancel"}}</button>
-						<button data-url="{{$.Link}}" class="ui primary button" id="new_board_submit">{{$.locale.Tr "repo.projects.column.new_submit"}}</button>
+						<button class="ui cancel button">{{ctx.Locale.Tr "settings.cancel"}}</button>
+						<button data-url="{{$.Link}}" class="ui primary button" id="new_project_column_submit">{{ctx.Locale.Tr "repo.projects.column.new_submit"}}</button>
 					</div>
 				</form>
 			</div>
 		</div>
-	</div>
-</div>
-<div class="divider"></div>
-<div class="ui two column stackable grid">
-	<div class="column">
-		<h2 class="project-title">{{$.Project.Title}}</h2>
-		<div class="content project-description">{{$.Project.RenderedContent|Str2html}}</div>
-	</div>
-	{{if $.CanWriteProjects}}
-		<div class="column right aligned">
-			<div class="ui compact right mini menu">
-				<a class="item" href="{{$.Link}}/edit?redirect=project">
-					{{svg "octicon-pencil"}}
-					<span class="gt-mx-3">{{$.locale.Tr "repo.issues.label_edit"}}</span>
-				</a>
-				{{if .Project.IsClosed}}
-					<a class="item link-action" href data-url="{{$.Link}}/open">
-						{{svg "octicon-check"}}
-						<span class="gt-mx-3">{{$.locale.Tr "repo.projects.open"}}</span>
-					</a>
-				{{else}}
-					<a class="item link-action" href data-url="{{$.Link}}/close">
-						{{svg "octicon-skip"}}
-						<span class="gt-mx-3">{{$.locale.Tr "repo.projects.close"}}</span>
-					</a>
-				{{end}}
-				<a class="item delete-button" href="#" data-url="{{$.Link}}/delete" data-id="{{.Project.ID}}">
-					{{svg "octicon-trash"}}
-					<span class="gt-mx-3">{{$.locale.Tr "repo.issues.label_delete"}}</span>
-				</a>
-			</div>
-		</div>
 	{{end}}
 </div>
 
+<div class="content">{{$.Project.RenderedContent|Str2html}}</div>
+
 <div class="divider"></div>
 
 <div id="project-board">
 	<div class="board {{if .CanWriteProjects}}sortable{{end}}">
-		{{range $board := .Boards}}
-		<div class="ui segment board-column" style="background: {{.Color}} !important;" data-id="{{.ID}}" data-sorting="{{.Sorting}}" data-url="{{$.Link}}/{{.ID}}">
-			<div class="board-column-header gt-df gt-ac gt-sb">
-				<div class="ui large label board-label gt-py-2">
-					<div class="ui small circular grey label board-card-cnt">
-						{{.NumIssues}}
-					</div>
-					{{.Title}}
-				</div>
-				{{if and $.CanWriteProjects (ne .ID 0)}}
-					<div class="ui dropdown jump item">
-						<div class="not-mobile gt-px-3" tabindex="-1">
-							{{svg "octicon-kebab-horizontal"}}
+		{{range .Columns}}
+			<div class="ui segment project-column" style="background: {{.Color}} !important;" data-id="{{.ID}}" data-sorting="{{.Sorting}}" data-url="{{$.Link}}/{{.ID}}">
+				<div class="project-column-header">
+					<div class="ui large label project-column-title gt-py-2">
+						<div class="ui small circular grey label project-column-issue-count">
+							{{.NumIssues}}
 						</div>
-						<div class="menu user-menu" tabindex="-1">
-							<a class="item show-modal button" data-modal="#edit-project-board-modal-{{.ID}}">
-								{{svg "octicon-pencil"}}
-								{{$.locale.Tr "repo.projects.column.edit"}}
-							</a>
-							{{if not .Default}}
-								<a class="item show-modal button default-project-board-show"
-								data-modal="#default-project-board-modal-{{.ID}}"
-								data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.set_default"}}"
-								data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.set_default_desc"}}"
-								data-url="{{$.Link}}/{{.ID}}/default">
-									{{svg "octicon-pin"}}
-									{{$.locale.Tr "repo.projects.column.set_default"}}
+						{{.Title}}
+					</div>
+					{{if and $canWriteProject (ne .ID 0)}}
+						<div class="ui dropdown jump item">
+							<div class="gt-px-3" tabindex="-1">
+								{{svg "octicon-kebab-horizontal"}}
+							</div>
+							<div class="menu user-menu" tabindex="-1">
+								<a class="item show-modal button" data-modal="#edit-project-column-modal-{{.ID}}">
+									{{svg "octicon-pencil"}}
+									{{ctx.Locale.Tr "repo.projects.column.edit"}}
 								</a>
-							{{else}}
-								<a class="item show-modal button default-project-board-show"
-								data-modal="#default-project-board-modal-{{.ID}}"
-								data-modal-default-project-board-header="{{$.locale.Tr "repo.projects.column.unset_default"}}"
-								data-modal-default-project-board-content="{{$.locale.Tr "repo.projects.column.unset_default_desc"}}"
-								data-url="{{$.Link}}/{{.ID}}/unsetdefault">
-									{{svg "octicon-pin-slash"}}
-									{{$.locale.Tr "repo.projects.column.unset_default"}}
+								{{if not .Default}}
+									<a class="item show-modal button default-project-column-show"
+									data-modal="#default-project-column-modal-{{.ID}}"
+									data-modal-default-project-column-header="{{ctx.Locale.Tr "repo.projects.column.set_default"}}"
+									data-modal-default-project-column-content="{{ctx.Locale.Tr "repo.projects.column.set_default_desc"}}"
+									data-url="{{$.Link}}/{{.ID}}/default">
+										{{svg "octicon-pin"}}
+										{{ctx.Locale.Tr "repo.projects.column.set_default"}}
+									</a>
+								{{else}}
+									<a class="item show-modal button default-project-column-show"
+									data-modal="#default-project-column-modal-{{.ID}}"
+									data-modal-default-project-column-header="{{ctx.Locale.Tr "repo.projects.column.unset_default"}}"
+									data-modal-default-project-column-content="{{ctx.Locale.Tr "repo.projects.column.unset_default_desc"}}"
+									data-url="{{$.Link}}/{{.ID}}/unsetdefault">
+										{{svg "octicon-pin-slash"}}
+										{{ctx.Locale.Tr "repo.projects.column.unset_default"}}
+									</a>
+								{{end}}
+								<a class="item show-modal button show-delete-project-column-modal"
+									data-modal="#delete-project-column-modal-{{.ID}}"
+									data-url="{{$.Link}}/{{.ID}}">
+									{{svg "octicon-trash"}}
+									{{ctx.Locale.Tr "repo.projects.column.delete"}}
 								</a>
-							{{end}}
-							<a class="item show-modal button show-delete-column-modal"
-								data-modal="#delete-board-modal-{{.ID}}"
-								data-url="{{$.Link}}/{{.ID}}"
-							>
-								{{svg "octicon-trash"}}
-								{{$.locale.Tr "repo.projects.column.delete"}}
-							</a>
 
-							<div class="ui small modal edit-project-board" id="edit-project-board-modal-{{.ID}}">
-								<div class="header">
-									{{$.locale.Tr "repo.projects.column.edit"}}
-								</div>
-								<div class="content">
-									<form class="ui form">
-										<div class="required field">
-											<label for="new_board_title">{{$.locale.Tr "repo.projects.column.edit_title"}}</label>
-											<input class="project-board-title" id="new_board_title" name="title" value="{{.Title}}" required>
-										</div>
+								<div class="ui small modal edit-project-column-modal" id="edit-project-column-modal-{{.ID}}">
+									<div class="header">
+										{{ctx.Locale.Tr "repo.projects.column.edit"}}
+									</div>
+									<div class="content">
+										<form class="ui form">
+											<div class="required field">
+												<label for="new_project_column_title">{{ctx.Locale.Tr "repo.projects.column.edit_title"}}</label>
+												<input class="project-column-title-input" id="new_project_column_title" name="title" value="{{.Title}}" required>
+											</div>
 
-										<div class="field color-field">
-											<label for="new_board_color">{{$.locale.Tr "repo.projects.column.color"}}</label>
-											<div class="color picker column">
-												<input class="color-picker" maxlength="7" placeholder="#c320f6" id="new_board_color" name="color" value="{{.Color}}">
-												<div class="column precolors">
-													{{template "repo/issue/label_precolors"}}
+											<div class="field color-field">
+												<label for="new_project_column_color">{{ctx.Locale.Tr "repo.projects.column.color"}}</label>
+												<div class="color picker column">
+													<input class="color-picker" maxlength="7" placeholder="#c320f6" id="new_project_column_color" name="color" value="{{.Color}}">
+													<div class="column precolors">
+														{{template "repo/issue/label_precolors"}}
+													</div>
 												</div>
 											</div>
-										</div>
 
-										<div class="text right actions">
-											<button class="ui cancel button">{{$.locale.Tr "settings.cancel"}}</button>
-											<button data-url="{{$.Link}}/{{.ID}}" class="ui primary button edit-column-button">{{$.locale.Tr "repo.projects.column.edit"}}</button>
-										</div>
-									</form>
+											<div class="text right actions">
+												<button class="ui cancel button">{{ctx.Locale.Tr "settings.cancel"}}</button>
+												<button data-url="{{$.Link}}/{{.ID}}" class="ui primary button edit-project-column-button">{{ctx.Locale.Tr "repo.projects.column.edit"}}</button>
+											</div>
+										</form>
+									</div>
 								</div>
-							</div>
 
-							<div class="ui g-modal-confirm modal default-project-board-modal" id="default-project-board-modal-{{.ID}}">
-								<div class="header">
-									<span id="default-project-board-header"></span>
-								</div>
-								<div class="content">
-									<label id="default-project-board-content"></label>
+								<div class="ui g-modal-confirm modal default-project-column-modal" id="default-project-column-modal-{{.ID}}">
+									<div class="header">
+										<span id="default-project-column-header"></span>
+									</div>
+									<div class="content">
+										<label id="default-project-column-content"></label>
+									</div>
+									{{template "base/modal_actions_confirm" (dict "locale" ctx.Locale "ModalButtonTypes" "confirm")}}
 								</div>
-								{{template "base/modal_actions_confirm" (dict "locale" $.locale "ModalButtonTypes" "confirm")}}
-							</div>
 
-							<div class="ui g-modal-confirm modal" id="delete-board-modal-{{.ID}}">
-								<div class="header">
-									{{$.locale.Tr "repo.projects.column.delete"}}
-								</div>
-								<div class="content">
-									<label>
-										{{$.locale.Tr "repo.projects.column.deletion_desc"}}
-									</label>
+								<div class="ui g-modal-confirm modal" id="delete-project-column-modal-{{.ID}}">
+									<div class="header">
+										{{ctx.Locale.Tr "repo.projects.column.delete"}}
+									</div>
+									<div class="content">
+										<label>
+											{{ctx.Locale.Tr "repo.projects.column.deletion_desc"}}
+										</label>
+									</div>
+									{{template "base/modal_actions_confirm" (dict "locale" ctx.Locale "ModalButtonTypes" "confirm")}}
 								</div>
-								{{template "base/modal_actions_confirm" (dict "locale" $.locale "ModalButtonTypes" "confirm")}}
 							</div>
 						</div>
-					</div>
-				{{end}}
-			</div>
-			<div class="divider"></div>
-
-			<div class="ui cards board" data-url="{{$.Link}}/{{.ID}}" data-project="{{$.Project.ID}}" data-board="{{.ID}}" id="board_{{.ID}}">
-
-				{{range (index $.IssuesMap .ID)}}
-
-				<!-- start issue card -->
-				<div class="card board-card" data-issue="{{.ID}}">
-					{{if eq $.Project.CardType 1}}{{/* Images and Text*/}}
-						<div class="card-attachment-images">
-							{{range (index $.issuesAttachmentMap .ID)}}
-								<img src="{{.DownloadURL}}" alt="{{.Name}}" />
-							{{end}}
-						</div>
 					{{end}}
-					<div class="content gt-p-0">
-						<div class="header">
-							<span class="gt-dif gt-ac gt-vm">
-								{{template "shared/issueicon" .}}
-							</span>
-							<a class="project-board-title gt-vm" href="{{.Link}}">
-								{{.Title}}
-							</a>
-						</div>
-						<div class="meta gt-my-2">
-							<span class="text light grey">
-								{{.Repo.FullName}}#{{.Index}}
-								{{$timeStr := TimeSinceUnix .GetLastEventTimestamp $.locale}}
-								{{if .OriginalAuthor}}
-									{{$.locale.Tr .GetLastEventLabelFake $timeStr (.OriginalAuthor|Escape) | Safe}}
-								{{else if gt .Poster.ID 0}}
-									{{$.locale.Tr .GetLastEventLabel $timeStr (.Poster.HomeLink|Escape) (.Poster.GetDisplayName | Escape) | Safe}}
-								{{else}}
-									{{$.locale.Tr .GetLastEventLabelFake $timeStr (.Poster.GetDisplayName | Escape) | Safe}}
-								{{end}}
-							</span>
-						</div>
-						{{- if .MilestoneID}}
-						<div class="meta gt-my-2">
-							<a class="milestone" href="{{$.RepoLink}}/milestone/{{.MilestoneID}}">
-								{{svg "octicon-milestone" 16 "gt-mr-2 gt-vm"}}
-								<span class="gt-vm">{{.Milestone.Name}}</span>
-							</a>
-						</div>
-						{{- end}}
-						{{- range index $.LinkedPRs .ID}}
-						<div class="meta gt-my-2">
-							<a href="{{$.RepoLink}}/pulls/{{.Index}}">
-								<span class="gt-m-0 text {{if .PullRequest.HasMerged}}purple{{else if .IsClosed}}red{{else}}green{{end}}">{{svg "octicon-git-merge" 16 "gt-mr-2 gt-vm"}}</span>
-								<span class="gt-vm">{{.Title}} <span class="text light grey">#{{.Index}}</span></span>
-							</a>
-						</div>
-						{{- end}}
-					</div>
+				</div>
 
-					{{if or .Labels .Assignees}}
-					<div class="extra content labels-list gt-p-0 gt-pt-2">
-						{{range .Labels}}
-							<a target="_blank" href="{{$.RepoLink}}/issues?labels={{.ID}}">{{RenderLabel $.Context .}}</a>
-						{{end}}
-						<div class="right floated">
-							{{range .Assignees}}
-								<a target="_blank" href="{{.HomeLink}}" data-tooltip-content="{{$.locale.Tr "repo.projects.column.assigned_to"}} {{.Name}}">{{ctx.AvatarUtils.Avatar . 28 "mini gt-mr-3"}}</a>
-							{{end}}
+				<div class="divider"></div>
+
+				<div class="ui cards {{if $.CanWriteProjects}}gt-cursor-grab{{end}}" data-url="{{$.Link}}/{{.ID}}" data-project="{{$.Project.ID}}" data-board="{{.ID}}" id="board_{{.ID}}">
+					{{range (index $.IssuesMap .ID)}}
+						<div class="issue-card gt-word-break" data-issue="{{.ID}}">
+							{{template "repo/issue/card" (dict "Issue" . "Page" $)}}
 						</div>
-					</div>
 					{{end}}
 				</div>
-				<!-- stop issue card -->
-
-				{{end}}
 			</div>
-		</div>
 		{{end}}
 	</div>
-
 </div>
 
 {{if .CanWriteProjects}}
 	<div class="ui g-modal-confirm delete modal">
 		<div class="header">
 			{{svg "octicon-trash"}}
-			{{.locale.Tr "repo.projects.deletion"}}
+			{{ctx.Locale.Tr "repo.projects.deletion"}}
 		</div>
 		<div class="content">
-			<p>{{.locale.Tr "repo.projects.deletion_desc"}}</p>
+			<p>{{ctx.Locale.Tr "repo.projects.deletion_desc"}}</p>
 		</div>
 		{{template "base/modal_actions_confirm" .}}
 	</div>