diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-04-08 21:15:22 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-08 21:15:22 +0800 |
| commit | fdbd64611383f8b78dc76765f6edfa3e40a3a0bf (patch) | |
| tree | dae3fa75aeaf28a8abd9565fb544ae8b72d9e530 /templates/repo/diff/stats.tmpl | |
| parent | cf5a281fdc23543584a3a06fcfcf796b08425a79 (diff) | |
| download | gitea-fdbd64611383f8b78dc76765f6edfa3e40a3a0bf.tar.gz gitea-fdbd64611383f8b78dc76765f6edfa3e40a3a0bf.zip | |
Group template helper functions, remove `Printf`, improve template error messages (#23982)
Follow #23328
Major changes:
* Group the function in `templates/help.go` by their purposes. It could
make future work easier.
* Remove the `Printf` helper function, there is already a builtin
`printf`.
* Remove `DiffStatsWidth`, replace with `Eval` in template
* Rename the `NewTextFuncMap` to `mailSubjectTextFuncMap`, it's for
subject text template only, no need to make it support HTML functions.
----
And fine tune template error messages, to make it more friendly to
developers and users.
---------
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'templates/repo/diff/stats.tmpl')
| -rw-r--r-- | templates/repo/diff/stats.tmpl | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/templates/repo/diff/stats.tmpl b/templates/repo/diff/stats.tmpl index 1e466d6b46..ff7e90d29c 100644 --- a/templates/repo/diff/stats.tmpl +++ b/templates/repo/diff/stats.tmpl @@ -1,4 +1,5 @@ {{Eval .file.Addition "+" .file.Deletion}} <span class="diff-stats-bar gt-mx-3" data-tooltip-content="{{.root.locale.Tr "repo.diff.stats_desc_file" (Eval .file.Addition "+" .file.Deletion) .file.Addition .file.Deletion | Str2html}}"> - <div class="diff-stats-add-bar" style="width: {{DiffStatsWidth .file.Addition .file.Deletion}}%"></div> + {{/* if the denominator is zero, then the float result is "width: NaNpx", as before, it just works */}} + <div class="diff-stats-add-bar" style="width: {{Eval 100 "*" .file.Addition "/" "(" .file.Addition "+" .file.Deletion "+" 0.0 ")"}}%"></div> </span> |