diff options
| author | delvh <leon@kske.dev> | 2023-03-14 04:34:09 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-14 11:34:09 +0800 |
| commit | 81fe5d61851c0e586af7d32c29171ceff9a571bb (patch) | |
| tree | 40ea13c9726cfca88a83800b323b428438cd90e9 /templates/repo/release | |
| parent | 605fd15ad6eda19dba8f5e8a8f2e595e34e6c6ee (diff) | |
| download | gitea-81fe5d61851c0e586af7d32c29171ceff9a571bb.tar.gz gitea-81fe5d61851c0e586af7d32c29171ceff9a571bb.zip | |
Convert `<div class="button">` to `<button class="button">` (#23337)
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice
Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.
## Future improvements
As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'templates/repo/release')
| -rw-r--r-- | templates/repo/release/new.tmpl | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/templates/repo/release/new.tmpl b/templates/repo/release/new.tmpl index d7c580fed9..8c4df98d19 100644 --- a/templates/repo/release/new.tmpl +++ b/templates/repo/release/new.tmpl @@ -114,7 +114,7 @@ {{$.locale.Tr "repo.release.delete_release"}} </a> {{if .IsDraft}} - <input class="ui button" type="submit" name="draft" value="{{.locale.Tr "repo.release.save_draft"}}"/> + <button class="ui button" type="submit" name="draft" value="{{.locale.Tr "repo.release.save_draft"}}">{{.locale.Tr "repo.release.save_draft"}}</button> <button class="ui primary button"> {{.locale.Tr "repo.release.publish"}} </button> @@ -125,9 +125,9 @@ {{end}} {{else}} {{if not .tag_name}} - <input class="ui grey button" type="submit" name="tag_only" value="{{.locale.Tr "repo.release.add_tag"}}"/> + <button class="ui grey button" type="submit" name="tag_only" value="{{.locale.Tr "repo.release.add_tag"}}">{{.locale.Tr "repo.release.add_tag"}}</button> {{end}} - <input class="ui button" type="submit" name="draft" value="{{.locale.Tr "repo.release.save_draft"}}"/> + <button class="ui button" type="submit" name="draft" value="{{.locale.Tr "repo.release.save_draft"}}">{{.locale.Tr "repo.release.save_draft"}}</button> <button class="ui primary button"> {{.locale.Tr "repo.release.publish"}} </button> |