diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-03-17 11:08:05 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-17 11:08:05 +0800 |
| commit | 345aa0975676031b97a99cc7a449d5fd680dba77 (patch) | |
| tree | a4a03455124f9bc49da9cd75eabfc168db7e77c4 /templates | |
| parent | e200c68bad4ea7fb8d6a76e04004857a0ade9fb3 (diff) | |
| download | gitea-345aa0975676031b97a99cc7a449d5fd680dba77.tar.gz gitea-345aa0975676031b97a99cc7a449d5fd680dba77.zip | |
Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450)
This PR is extracted from #23346 to address some unclear (I don't
understand) code-belonging concerns.
This PR needs to be backported, otherwise the `aria.js` is too buggy in
some cases. Since there would be two minor conflicts, I will do the
backport manually.
Before: the `aria.js` is still buggy in some cases.
After: tested with AppleVoice, Android TalkBack
* Fix incorrect dropdown init code
* Fix incorrect role element (the menu role should be on the `$menu`
element, but not on the `$focusable`)
* Fix the focus-show-click-hide problem on mobile. Now the language menu
works as expected
* Fix incorrect dropdown template function setting
* Clarify the logic in aria.js
* Hide item's tippy after menu gets hidden
* Fix incorrect tippy `setProps` after `destroy`
* Fix UI lag problem when page gets redirected during menu hiding
animation with screen reader
* Improve comments
* Implement the layout proposed by #19861
<details>
https://github.com/go-gitea/gitea/blob/d74a7efb60f94a4b8e6e5f65332f94f1be31b761/web_src/js/features/aria.md?plain=1#L38-L47
</details>
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/base/footer_content.tmpl | 2 | ||||
| -rw-r--r-- | templates/repo/issue/view_content/add_reaction.tmpl | 2 | ||||
| -rw-r--r-- | templates/repo/issue/view_content/context_menu.tmpl | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/templates/base/footer_content.tmpl b/templates/base/footer_content.tmpl index c3b96a0245..53d0a2c77c 100644 --- a/templates/base/footer_content.tmpl +++ b/templates/base/footer_content.tmpl @@ -21,7 +21,7 @@ {{end}} <div class="ui language bottom floating slide up dropdown link item"> {{svg "octicon-globe"}} - <div class="text">{{.locale.LangName}}</div> + <span>{{.locale.LangName}}</span> <div class="menu language-menu"> {{range .AllLangs}} <a lang="{{.Lang}}" data-url="{{AppSubUrl}}/?lang={{.Lang}}" class="item {{if eq $.locale.Lang .Lang}}active selected{{end}}">{{.Name}}</a> diff --git a/templates/repo/issue/view_content/add_reaction.tmpl b/templates/repo/issue/view_content/add_reaction.tmpl index 692d09e679..94c1813bf7 100644 --- a/templates/repo/issue/view_content/add_reaction.tmpl +++ b/templates/repo/issue/view_content/add_reaction.tmpl @@ -1,5 +1,5 @@ {{if .ctxData.IsSigned}} -<div class="item action ui pointing select-reaction dropdown top right" data-action-url="{{.ActionURL}}"> +<div class="item action ui dropdown jump pointing top right select-reaction" data-action-url="{{.ActionURL}}"> <a class="add-reaction"> {{svg "octicon-smiley"}} </a> diff --git a/templates/repo/issue/view_content/context_menu.tmpl b/templates/repo/issue/view_content/context_menu.tmpl index c073c74ea3..0cc207afd4 100644 --- a/templates/repo/issue/view_content/context_menu.tmpl +++ b/templates/repo/issue/view_content/context_menu.tmpl @@ -1,5 +1,5 @@ {{if .ctxData.IsSigned}} -<div class="item action ui pointing custom dropdown top right context-dropdown"> +<div class="item action ui dropdown jump pointing top right context-dropdown"> <a class="context-menu"> {{svg "octicon-kebab-horizontal"}} </a> |