diff options
| author | Nanguan Lin <70063547+lng2020@users.noreply.github.com> | 2023-10-11 19:02:24 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-11 11:02:24 +0000 |
| commit | dc04044716088e3786497e200abe1fdfb3a943b6 (patch) | |
| tree | 45230f2067cbf0f130042e33eed36a38ed69e9b1 /tests/integration/api_token_test.go | |
| parent | dca195e9bd0d14a5cf888524e51175da8ab24588 (diff) | |
| download | gitea-dc04044716088e3786497e200abe1fdfb3a943b6.tar.gz gitea-dc04044716088e3786497e200abe1fdfb3a943b6.zip | |
Replace assert.Fail with assert.FailNow (#27578)
assert.Fail() will continue to execute the code while assert.FailNow()
not. I thought those uses of assert.Fail() should exit immediately.
PS: perhaps it's a good idea to use
[require](https://pkg.go.dev/github.com/stretchr/testify/require)
somewhere because the assert package's default behavior does not exit
when an error occurs, which makes it difficult to find the root error
reason.
Diffstat (limited to 'tests/integration/api_token_test.go')
| -rw-r--r-- | tests/integration/api_token_test.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tests/integration/api_token_test.go b/tests/integration/api_token_test.go index a713922982..fe0e44d97f 100644 --- a/tests/integration/api_token_test.go +++ b/tests/integration/api_token_test.go @@ -483,8 +483,7 @@ func runTestCase(t *testing.T, testCase *requiredScopeTestCase, user *user_model } else if minRequiredLevel == auth_model.Write { unauthorizedLevel = auth_model.Read } else { - assert.Failf(t, "Invalid test case", "Unknown access token scope level: %v", minRequiredLevel) - return + assert.FailNow(t, "Invalid test case: Unknown access token scope level: %v", minRequiredLevel) } } |