diff options
| author | silverwind <me@silverwind.io> | 2024-06-10 22:49:33 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-10 22:49:33 +0200 |
| commit | 507fbf4c3ceffba9143edbe421a134b904210a4c (patch) | |
| tree | 9ff231551355bed43efdab5d27d7723b151c16b2 /web_src/js/features/colorpicker.js | |
| parent | a2304cb163ce5e097078e71f49d4d5cb4c8b20d9 (diff) | |
| download | gitea-507fbf4c3ceffba9143edbe421a134b904210a4c.tar.gz gitea-507fbf4c3ceffba9143edbe421a134b904210a4c.zip | |
Use `querySelector` over alternative DOM methods (#31280)
As per
https://github.com/go-gitea/gitea/pull/30115#discussion_r1626060164,
prefer `querySelector` by enabling
[`unicorn/prefer-query-selector`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-query-selector.md)
and autofixing all except 10 issues.
According to
[this](https://old.reddit.com/r/learnjavascript/comments/i0f5o8/performance_of_getelementbyid_vs_queryselector/),
querySelector may be faster as well, so it's a win-win.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'web_src/js/features/colorpicker.js')
| -rw-r--r-- | web_src/js/features/colorpicker.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/web_src/js/features/colorpicker.js b/web_src/js/features/colorpicker.js index 6d00d908c9..a85c04de41 100644 --- a/web_src/js/features/colorpicker.js +++ b/web_src/js/features/colorpicker.js @@ -1,7 +1,7 @@ import {createTippy} from '../modules/tippy.js'; export async function initColorPickers() { - const els = document.getElementsByClassName('js-color-picker-input'); + const els = document.querySelectorAll('.js-color-picker-input'); if (!els.length) return; await Promise.all([ |