diff options
| author | silverwind <me@silverwind.io> | 2024-06-10 22:49:33 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-10 22:49:33 +0200 |
| commit | 507fbf4c3ceffba9143edbe421a134b904210a4c (patch) | |
| tree | 9ff231551355bed43efdab5d27d7723b151c16b2 /web_src/js/features/install.js | |
| parent | a2304cb163ce5e097078e71f49d4d5cb4c8b20d9 (diff) | |
| download | gitea-507fbf4c3ceffba9143edbe421a134b904210a4c.tar.gz gitea-507fbf4c3ceffba9143edbe421a134b904210a4c.zip | |
Use `querySelector` over alternative DOM methods (#31280)
As per
https://github.com/go-gitea/gitea/pull/30115#discussion_r1626060164,
prefer `querySelector` by enabling
[`unicorn/prefer-query-selector`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-query-selector.md)
and autofixing all except 10 issues.
According to
[this](https://old.reddit.com/r/learnjavascript/comments/i0f5o8/performance_of_getelementbyid_vs_queryselector/),
querySelector may be faster as well, so it's a win-win.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'web_src/js/features/install.js')
| -rw-r--r-- | web_src/js/features/install.js | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/web_src/js/features/install.js b/web_src/js/features/install.js index 54ba3778f8..6354db6cdc 100644 --- a/web_src/js/features/install.js +++ b/web_src/js/features/install.js @@ -22,12 +22,12 @@ function initPreInstall() { mssql: '127.0.0.1:1433', }; - const dbHost = document.getElementById('db_host'); - const dbUser = document.getElementById('db_user'); - const dbName = document.getElementById('db_name'); + const dbHost = document.querySelector('#db_host'); + const dbUser = document.querySelector('#db_user'); + const dbName = document.querySelector('#db_name'); // Database type change detection. - document.getElementById('db_type').addEventListener('change', function () { + document.querySelector('#db_type').addEventListener('change', function () { const dbType = this.value; hideElem('div[data-db-setting-for]'); showElem(`div[data-db-setting-for=${dbType}]`); @@ -46,14 +46,14 @@ function initPreInstall() { } } // else: for SQLite3, the default path is always prepared by backend code (setting) }); - document.getElementById('db_type').dispatchEvent(new Event('change')); + document.querySelector('#db_type').dispatchEvent(new Event('change')); - const appUrl = document.getElementById('app_url'); + const appUrl = document.querySelector('#app_url'); if (appUrl.value.includes('://localhost')) { appUrl.value = window.location.href; } - const domain = document.getElementById('domain'); + const domain = document.querySelector('#domain'); if (domain.value.trim() === 'localhost') { domain.value = window.location.hostname; } @@ -103,7 +103,7 @@ function initPreInstall() { } function initPostInstall() { - const el = document.getElementById('goto-user-login'); + const el = document.querySelector('#goto-user-login'); if (!el) return; const targetUrl = el.getAttribute('href'); |