aboutsummaryrefslogtreecommitdiffstats
path: root/web_src/js/modules/fomantic/modal.ts
diff options
context:
space:
mode:
authorsilverwind <me@silverwind.io>2024-07-07 17:32:30 +0200
committerGitHub <noreply@github.com>2024-07-07 15:32:30 +0000
commit5791a73e75b630db3cade3e606c45eb8d8a641cb (patch)
tree3042132ac6f486723ff2ae42245a5b8a09d98c72 /web_src/js/modules/fomantic/modal.ts
parent5115c278ff8f3f8beebb172ce20a939a10476dfd (diff)
downloadgitea-5791a73e75b630db3cade3e606c45eb8d8a641cb.tar.gz
gitea-5791a73e75b630db3cade3e606c45eb8d8a641cb.zip
Convert frontend code to typescript (#31559)
None of the frontend js/ts files was touched besides these two commands (edit: no longer true, I touched one file in https://github.com/go-gitea/gitea/pull/31559/commits/61105d0618e285d97e95044bfb64415f364a4526 because of a deprecation that was not showing before the rename). `tsc` currently reports 778 errors, so I have disabled it in CI as planned. Everything appears to work fine.
Diffstat (limited to 'web_src/js/modules/fomantic/modal.ts')
-rw-r--r--web_src/js/modules/fomantic/modal.ts28
1 files changed, 28 insertions, 0 deletions
diff --git a/web_src/js/modules/fomantic/modal.ts b/web_src/js/modules/fomantic/modal.ts
new file mode 100644
index 0000000000..8b455cf4de
--- /dev/null
+++ b/web_src/js/modules/fomantic/modal.ts
@@ -0,0 +1,28 @@
+import $ from 'jquery';
+
+const fomanticModalFn = $.fn.modal;
+
+// use our own `$.fn.modal` to patch Fomantic's modal module
+export function initAriaModalPatch() {
+ if ($.fn.modal === ariaModalFn) throw new Error('initAriaModalPatch could only be called once');
+ $.fn.modal = ariaModalFn;
+ ariaModalFn.settings = fomanticModalFn.settings;
+}
+
+// the patched `$.fn.modal` modal function
+// * it does the one-time attaching on the first call
+function ariaModalFn(...args) {
+ const ret = fomanticModalFn.apply(this, args);
+ if (args[0] === 'show' || args[0]?.autoShow) {
+ for (const el of this) {
+ // If there is a form in the modal, there might be a "cancel" button before "ok" button (all buttons are "type=submit" by default).
+ // In such case, the "Enter" key will trigger the "cancel" button instead of "ok" button, then the dialog will be closed.
+ // It breaks the user experience - the "Enter" key should confirm the dialog and submit the form.
+ // So, all "cancel" buttons without "[type]" must be marked as "type=button".
+ for (const button of el.querySelectorAll('form button.cancel:not([type])')) {
+ button.setAttribute('type', 'button');
+ }
+ }
+ }
+ return ret;
+}