aboutsummaryrefslogtreecommitdiffstats
path: root/web_src
diff options
context:
space:
mode:
authorHester Gong <hestergong@gmail.com>2023-03-07 23:08:22 +0800
committerGitHub <noreply@github.com>2023-03-07 23:08:22 +0800
commita2f44463f07cc184b0d6ca1655d1f26d75491896 (patch)
tree60257263a41c32760e9c0e1136e2e43720f9e2d0 /web_src
parent4c59c8c7682da31410decba3bd868fde5116e073 (diff)
downloadgitea-a2f44463f07cc184b0d6ca1655d1f26d75491896.tar.gz
gitea-a2f44463f07cc184b0d6ca1655d1f26d75491896.zip
Fix adding of empty class name (#23352)
This PR is to fix the error shown below. The reason is because [`class-name` prop](https://github.com/go-gitea/gitea/blob/main/web_src/js/components/ActionRunStatus.vue#L6) given to `svg` component has a space, and classList cannot add empty string. https://user-images.githubusercontent.com/17645053/223346720-c7f9de43-5e69-4ecf-93c0-90bf04090693.mov --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'web_src')
-rw-r--r--web_src/js/svg.js3
1 files changed, 2 insertions, 1 deletions
diff --git a/web_src/js/svg.js b/web_src/js/svg.js
index 2132ad3120..6476f16bfb 100644
--- a/web_src/js/svg.js
+++ b/web_src/js/svg.js
@@ -80,7 +80,8 @@ export function svg(name, size = 16, className = '') {
const svgNode = document.firstChild;
if (size !== 16) svgNode.setAttribute('width', String(size));
if (size !== 16) svgNode.setAttribute('height', String(size));
- if (className) svgNode.classList.add(...className.split(/\s+/));
+ // filter array to remove empty string
+ if (className) svgNode.classList.add(...className.split(/\s+/).filter(Boolean));
return serializer.serializeToString(svgNode);
}