aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--modules/packages/conan/reference.go9
-rw-r--r--modules/packages/conan/reference_test.go1
2 files changed, 6 insertions, 4 deletions
diff --git a/modules/packages/conan/reference.go b/modules/packages/conan/reference.go
index c43446e6e5..49236981b6 100644
--- a/modules/packages/conan/reference.go
+++ b/modules/packages/conan/reference.go
@@ -8,10 +8,9 @@ import (
"errors"
"fmt"
"regexp"
+ "strings"
"code.gitea.io/gitea/modules/log"
-
- goversion "github.com/hashicorp/go-version"
)
const (
@@ -56,7 +55,9 @@ func NewRecipeReference(name, version, user, channel, revision string) (*RecipeR
if !namePattern.MatchString(name) {
return nil, ErrValidation
}
- if _, err := goversion.NewSemver(version); err != nil {
+
+ v := strings.TrimSpace(version)
+ if v == "" {
return nil, ErrValidation
}
if user != "" && !namePattern.MatchString(user) {
@@ -69,7 +70,7 @@ func NewRecipeReference(name, version, user, channel, revision string) (*RecipeR
return nil, ErrValidation
}
- return &RecipeReference{name, version, user, channel, revision}, nil
+ return &RecipeReference{name, v, user, channel, revision}, nil
}
func (r *RecipeReference) RevisionOrDefault() string {
diff --git a/modules/packages/conan/reference_test.go b/modules/packages/conan/reference_test.go
index 29ba3a543b..98eb2c8478 100644
--- a/modules/packages/conan/reference_test.go
+++ b/modules/packages/conan/reference_test.go
@@ -34,6 +34,7 @@ func TestNewRecipeReference(t *testing.T) {
{"name", "1.0", "_", "_", "", true},
{"name", "1.0", "_", "_", "0", true},
{"name", "1.0", "", "", "0", true},
+ {"name", "1.0.0q", "", "", "0", true},
{"name", "1.0", "", "", "000000000000000000000000000000000000000000000000000000000000", false},
}