diff options
Diffstat (limited to 'web_src')
-rw-r--r-- | web_src/css/base.css | 4 | ||||
-rw-r--r-- | web_src/js/components/DiffFileTreeItem.vue | 16 | ||||
-rw-r--r-- | web_src/js/components/RepoBranchTagSelector.vue | 3 | ||||
-rw-r--r-- | web_src/js/components/RepoContributors.vue | 2 | ||||
-rw-r--r-- | web_src/js/modules/diff-file.test.ts | 6 | ||||
-rw-r--r-- | web_src/js/modules/diff-file.ts | 10 |
6 files changed, 22 insertions, 19 deletions
diff --git a/web_src/css/base.css b/web_src/css/base.css index 204b6a1560..dc79f2f322 100644 --- a/web_src/css/base.css +++ b/web_src/css/base.css @@ -29,6 +29,7 @@ --checkbox-size: 15px; /* height and width of checkbox and radio inputs */ --page-spacing: 16px; /* space between page elements */ --page-margin-x: 32px; /* minimum space on left and right side of page */ + --page-space-bottom: 64px; /* space between last page element and footer */ } @media (min-width: 768px) and (max-width: 1200px) { @@ -479,7 +480,7 @@ img.ui.avatar, .full.height { flex-grow: 1; - padding-bottom: 80px; + padding-bottom: var(--page-space-bottom); } .status-page-error { @@ -1149,6 +1150,7 @@ table th[data-sortt-desc] .svg { min-width: 0; } +.ui.dropdown > .ui.button, .flex-text-block > .ui.button, .flex-text-inline > .ui.button { margin: 0; /* fomantic buttons have default margin, when we use them in a flex container with gap, we do not need these margins */ diff --git a/web_src/js/components/DiffFileTreeItem.vue b/web_src/js/components/DiffFileTreeItem.vue index d6d5506155..24bf590082 100644 --- a/web_src/js/components/DiffFileTreeItem.vue +++ b/web_src/js/components/DiffFileTreeItem.vue @@ -22,13 +22,6 @@ function getIconForDiffStatus(pType: DiffStatus) { }; return diffTypes[pType] ?? diffTypes['']; } - -function entryIcon(entry: DiffTreeEntry) { - if (entry.EntryMode === 'commit') { - return 'octicon-file-submodule'; - } - return 'octicon-file'; -} </script> <template> @@ -36,10 +29,8 @@ function entryIcon(entry: DiffTreeEntry) { <div class="item-directory" :class="{ 'viewed': item.IsViewed }" :title="item.DisplayName" @click.stop="collapsed = !collapsed"> <!-- directory --> <SvgIcon :name="collapsed ? 'octicon-chevron-right' : 'octicon-chevron-down'"/> - <SvgIcon - class="text primary" - :name="collapsed ? 'octicon-file-directory-fill' : 'octicon-file-directory-open-fill'" - /> + <!-- eslint-disable-next-line vue/no-v-html --> + <span class="tw-contents" v-html="collapsed ? store.folderIcon : store.folderOpenIcon"/> <span class="gt-ellipsis">{{ item.DisplayName }}</span> </div> @@ -53,7 +44,8 @@ function entryIcon(entry: DiffTreeEntry) { :title="item.DisplayName" :href="'#diff-' + item.NameHash" > <!-- file --> - <SvgIcon :name="entryIcon(item)"/> + <!-- eslint-disable-next-line vue/no-v-html --> + <span class="tw-contents" v-html="item.FileIcon"/> <span class="gt-ellipsis tw-flex-1">{{ item.DisplayName }}</span> <SvgIcon :name="getIconForDiffStatus(item.DiffStatus).name" diff --git a/web_src/js/components/RepoBranchTagSelector.vue b/web_src/js/components/RepoBranchTagSelector.vue index aaef8045a0..8e3a29a0e0 100644 --- a/web_src/js/components/RepoBranchTagSelector.vue +++ b/web_src/js/components/RepoBranchTagSelector.vue @@ -222,7 +222,8 @@ export default defineComponent({ <template v-if="dropdownFixedText">{{ dropdownFixedText }}</template> <template v-else> <svg-icon v-if="currentRefType === 'tag'" name="octicon-tag"/> - <svg-icon v-else name="octicon-git-branch"/> + <svg-icon v-else-if="currentRefType === 'branch'" name="octicon-git-branch"/> + <svg-icon v-else name="octicon-git-commit"/> <strong ref="dropdownRefName" class="tw-inline-block gt-ellipsis">{{ currentRefShortName }}</strong> </template> </span> diff --git a/web_src/js/components/RepoContributors.vue b/web_src/js/components/RepoContributors.vue index 969a869e0d..1006ea30bb 100644 --- a/web_src/js/components/RepoContributors.vue +++ b/web_src/js/components/RepoContributors.vue @@ -354,7 +354,7 @@ export default defineComponent({ <div> <!-- Contribution type --> <div class="ui floating dropdown jump" id="repo-contributors"> - <div class="ui basic compact button tw-mr-0"> + <div class="ui basic compact button"> <span class="not-mobile">{{ locale.filterLabel }}</span> <strong>{{ locale.contributionType[type] }}</strong> <svg-icon name="octicon-triangle-down" :size="14"/> </div> diff --git a/web_src/js/modules/diff-file.test.ts b/web_src/js/modules/diff-file.test.ts index 1f956a7d86..f0438538a0 100644 --- a/web_src/js/modules/diff-file.test.ts +++ b/web_src/js/modules/diff-file.test.ts @@ -9,6 +9,7 @@ test('diff-tree', () => { 'IsViewed': false, 'NameHash': '....', 'DiffStatus': '', + 'FileIcon': '', 'Children': [ { 'FullName': 'dir1', @@ -17,6 +18,7 @@ test('diff-tree', () => { 'IsViewed': false, 'NameHash': '....', 'DiffStatus': '', + 'FileIcon': '', 'Children': [ { 'FullName': 'dir1/test.txt', @@ -25,6 +27,7 @@ test('diff-tree', () => { 'NameHash': '....', 'EntryMode': '', 'IsViewed': false, + 'FileIcon': '', 'Children': null, }, ], @@ -36,11 +39,12 @@ test('diff-tree', () => { 'DiffStatus': 'added', 'EntryMode': '', 'IsViewed': false, + 'FileIcon': '', 'Children': null, }, ], }, - }); + }, '', ''); diffTreeStoreSetViewed(store, 'dir1/test.txt', true); expect(store.fullNameMap['dir1/test.txt'].IsViewed).toBe(true); expect(store.fullNameMap['dir1'].IsViewed).toBe(true); diff --git a/web_src/js/modules/diff-file.ts b/web_src/js/modules/diff-file.ts index 5d06f8a333..2cec7bc6b3 100644 --- a/web_src/js/modules/diff-file.ts +++ b/web_src/js/modules/diff-file.ts @@ -13,7 +13,7 @@ export type DiffTreeEntry = { EntryMode: string, IsViewed: boolean, Children: DiffTreeEntry[], - + FileIcon: string, ParentEntry?: DiffTreeEntry, } @@ -22,6 +22,8 @@ type DiffFileTreeData = { }; type DiffFileTree = { + folderIcon: string; + folderOpenIcon: string; diffFileTree: DiffFileTreeData; fullNameMap?: Record<string, DiffTreeEntry> fileTreeIsVisible: boolean; @@ -31,7 +33,7 @@ type DiffFileTree = { let diffTreeStoreReactive: Reactive<DiffFileTree>; export function diffTreeStore() { if (!diffTreeStoreReactive) { - diffTreeStoreReactive = reactiveDiffTreeStore(pageData.DiffFileTree); + diffTreeStoreReactive = reactiveDiffTreeStore(pageData.DiffFileTree, pageData.FolderIcon, pageData.FolderOpenIcon); } return diffTreeStoreReactive; } @@ -55,9 +57,11 @@ function fillFullNameMap(map: Record<string, DiffTreeEntry>, entry: DiffTreeEntr } } -export function reactiveDiffTreeStore(data: DiffFileTreeData): Reactive<DiffFileTree> { +export function reactiveDiffTreeStore(data: DiffFileTreeData, folderIcon: string, folderOpenIcon: string): Reactive<DiffFileTree> { const store = reactive({ diffFileTree: data, + folderIcon, + folderOpenIcon, fileTreeIsVisible: false, selectedItem: '', fullNameMap: {}, |