diff options
| author | David Pursehouse <david.pursehouse@gmail.com> | 2017-12-06 23:31:38 +0900 |
|---|---|---|
| committer | David Pursehouse <david.pursehouse@gmail.com> | 2017-12-12 00:39:21 -0500 |
| commit | c40e1507900e00b37c7dd07407b7fa32f557a9a7 (patch) | |
| tree | 4a76b340b7b9aa1ee71ed7ad816492df0755659c | |
| parent | 623851ec16ab3dc590dd2fb6a6197285dee9c6f7 (diff) | |
| download | jgit-c40e1507900e00b37c7dd07407b7fa32f557a9a7.tar.gz jgit-c40e1507900e00b37c7dd07407b7fa32f557a9a7.zip | |
InMemoryRepository: Make inner class MemObjDatabase static
FindBugs reports:
This class is an inner class, but does not use its embedded reference
to the object which created it. This reference makes the instances
of the class larger, and may keep the reference to the creator object
alive longer than necessary. If possible, the class should be made
static.
Change-Id: I9f49de32b4cd81b7ef1239b390353689263bf66e
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
| -rw-r--r-- | org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/InMemoryRepository.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/InMemoryRepository.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/InMemoryRepository.java index 383ed3d016..1e31878b39 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/InMemoryRepository.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/InMemoryRepository.java @@ -107,7 +107,7 @@ public class InMemoryRepository extends DfsRepository { } /** DfsObjDatabase used by InMemoryRepository. */ - public class MemObjDatabase extends DfsObjDatabase { + public static class MemObjDatabase extends DfsObjDatabase { private List<DfsPackDescription> packs = new ArrayList<>(); private int blockSize; |