diff options
| author | Shawn O. Pearce <spearce@spearce.org> | 2010-08-25 17:05:31 -0700 |
|---|---|---|
| committer | Shawn O. Pearce <spearce@spearce.org> | 2010-08-25 17:07:13 -0700 |
| commit | cb0c05b5b48702f8c8ef0aae2b398d685d4d41d5 (patch) | |
| tree | c28754353353cb8228e9722afb9ce57d5194385c | |
| parent | 7a9edb3662a4345573752b5a77710b6d2b28e7fa (diff) | |
| download | jgit-cb0c05b5b48702f8c8ef0aae2b398d685d4d41d5.tar.gz jgit-cb0c05b5b48702f8c8ef0aae2b398d685d4d41d5.zip | |
Increase the default streaming threshold to 15 MiB
Applying deltas in the large streaming mode is horrifically slow.
Trying to pack icu4c is impossible because a single 11 MiB file
sits on top of a 15 MiB file though a 10 deep delta chain, which
results in this very slow inflate process.
Upping the default limit to 15 MiB lets us process this large in a
reasonable time, but its still sufficiently low enough to prevent
exploding the heap of a very large process like Eclipse or Gerrit
Code Review.
We have to revisit the streaming delta application process and do
something much smarter, like flatten the delta chain before we apply
it to the base. But even that is ugly, I've seen a 155 MiB delta
sitting on top of a 450 MiB file to produce a 300 MiB result object.
If the chain is deep, we may have trouble flatting it down.
Change-Id: If5a0dcbf9d14ea683d75546f104b09bb8cd8fdbb
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| -rw-r--r-- | org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectLoader.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectLoader.java b/org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectLoader.java index 661a5e8eba..f638cc794c 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectLoader.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectLoader.java @@ -66,7 +66,7 @@ public abstract class ObjectLoader { * Objects larger than this size must be accessed as a stream through the * loader's {@link #openStream()} method. */ - public static final int STREAM_THRESHOLD = 1024 * 1024; + public static final int STREAM_THRESHOLD = 15 * 1024 * 1024; /** * @return Git in pack object type, see {@link Constants}. |