diff options
author | Ivan Frade <ifrade@google.com> | 2018-11-15 21:27:20 -0800 |
---|---|---|
committer | Ivan Frade <ifrade@google.com> | 2018-11-15 22:36:43 -0800 |
commit | d9ac7ddf1026123fee6c4477d172d614522dfc08 (patch) | |
tree | 031a110e54fc1158523fe8971443f8a4d9ba6df2 /org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver | |
parent | c56afbf18cb14402705a56ca6a2dff6441208cd3 (diff) | |
download | jgit-d9ac7ddf1026123fee6c4477d172d614522dfc08.tar.gz jgit-d9ac7ddf1026123fee6c4477d172d614522dfc08.zip |
Remove unnecessary modifiers from interfaces
From Oracle's "Defining an interface":
"All abstract, default, and static methods in an interface are
implicitly public, so you can omit the public modifier."
(Without any modifier, the interface methods are also abstract, so we
omit also the "abstract")
"In addition, an interface can contain constant declarations. All
constant values defined in an interface are implicitly public, static,
and final. Once again, you can omit these modifiers."
This makes the code more consistent. Now all interfaces under
org.eclipse.jgit follow the guidelines.
Change-Id: I4fe6deb111899ec1b4318ab5a6050f3851fa1fd3
Signed-off-by: Ivan Frade <ifrade@google.com>
Diffstat (limited to 'org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver')
3 files changed, 3 insertions, 3 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/ReceivePackFactory.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/ReceivePackFactory.java index 4967169776..b850d1ef94 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/ReceivePackFactory.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/ReceivePackFactory.java @@ -57,7 +57,7 @@ public interface ReceivePackFactory<C> { /** * A factory disabling the ReceivePack service for all repositories */ - public static final ReceivePackFactory<?> DISABLED = new ReceivePackFactory<Object>() { + ReceivePackFactory<?> DISABLED = new ReceivePackFactory<Object>() { @Override public ReceivePack create(Object req, Repository db) throws ServiceNotEnabledException { diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/RepositoryResolver.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/RepositoryResolver.java index a305e4cea3..4816f21bcc 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/RepositoryResolver.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/RepositoryResolver.java @@ -57,7 +57,7 @@ public interface RepositoryResolver<C> { /** * Resolver configured to open nothing. */ - public static final RepositoryResolver<?> NONE = new RepositoryResolver<Object>() { + RepositoryResolver<?> NONE = new RepositoryResolver<Object>() { @Override public Repository open(Object req, String name) throws RepositoryNotFoundException { diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/UploadPackFactory.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/UploadPackFactory.java index 40d1ffdc56..bb43b136d8 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/UploadPackFactory.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/UploadPackFactory.java @@ -57,7 +57,7 @@ public interface UploadPackFactory<C> { /** * A factory disabling the UploadPack service for all repositories. */ - public static final UploadPackFactory<?> DISABLED = new UploadPackFactory<Object>() { + UploadPackFactory<?> DISABLED = new UploadPackFactory<Object>() { @Override public UploadPack create(Object req, Repository db) throws ServiceNotEnabledException { |